Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createRDBESDataObject #210

Closed
Kasia-MIR opened this issue Oct 22, 2024 · 1 comment
Closed

createRDBESDataObject #210

Kasia-MIR opened this issue Oct 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Kasia-MIR
Copy link
Contributor

read.csv isn't sufficient function to read data.

Suggestion: use data.table::fread(file_path, stringsAsFactors=FALSE, verbose=FALSE, sep=",", na.strings="NULL",quote = "")

@davidcurrie2001
Copy link
Contributor

I've added some tests to check that the number of rows created when you import CSV data is correct. I've also added a copy of CL with bad data in the vessel identifiers field to the test data.

I think the problem is that you can currently upload vessel ids separated by commas in CLencryptedVesselIds if you quote the data (i.e. "abc,def,ghi") – but when you download that data you only get partial data values from that field (e.g. "abc).

I’ve raised an issue on the RDBES core group GitHub to request a check for commas during upload: ices-tools-dev/RDBES#212

@davidcurrie2001 davidcurrie2001 removed the 9_needs_more_tests Please add more tests label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants