Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fail Faster #233

Merged
merged 2 commits into from
Nov 3, 2023
Merged

CI: Fail Faster #233

merged 2 commits into from
Nov 3, 2023

Conversation

ric-evans
Copy link
Member

@ric-evans ric-evans commented Nov 3, 2023

If the test is going to fail (due to timeouts), this should happen sooner than later. Decrease default timeouts for this

@tianluyuan, going back to this: #211 (comment)
Since this PR, I added bash defaults to the env-vars.sh, so if you need to use the script for non-CI testing, then you can set your overriding env vars and this script will respect those.

@ric-evans ric-evans added the CI / Testing About CI and/or testing label Nov 3, 2023
@ric-evans ric-evans self-assigned this Nov 3, 2023
@ric-evans ric-evans marked this pull request as ready for review November 3, 2023 21:05
@ric-evans ric-evans merged commit 4d94112 into main Nov 3, 2023
32 checks passed
@ric-evans ric-evans deleted the fail-faster branch November 3, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI / Testing About CI and/or testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant