Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for timing #211

Merged
merged 35 commits into from
Sep 18, 2023
Merged

updates for timing #211

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
2caa370
updates for timing
tianluyuan Aug 18, 2023
0eb7c15
actually use the new function
tianluyuan Aug 18, 2023
8b829e6
type annotate and fix a typo
tianluyuan Aug 18, 2023
6d13a40
improt List
tianluyuan Aug 18, 2023
1240118
fix mypy error
tianluyuan Aug 18, 2023
7cd77dc
name to pulse_cleaning
tianluyuan Aug 18, 2023
3d03786
remove unused arg and revert brights threshold to 2
tianluyuan Aug 21, 2023
bb45677
Merge branch 'main' into updates_mlpd
tianluyuan Aug 23, 2023
cd6a4b5
<bot> update dependencies*.log files(s)
wipacdevbot Aug 23, 2023
47c1b85
set FIRST_NSIDE_PIXEL_EXTENSION to 0 as a placeholder
tianluyuan Aug 23, 2023
75f63ea
Merge branch 'main' into updates_mlpd
tianluyuan Aug 25, 2023
56c284b
increase relerr
tianluyuan Sep 7, 2023
b93d6e2
Merge branch 'main' into updates_mlpd
tianluyuan Sep 7, 2023
2dad125
<bot> update dependencies*.log files(s)
wipacdevbot Sep 7, 2023
a44cf6d
add hivecleaning
tianluyuan Sep 8, 2023
194b94f
small refactor
tianluyuan Sep 8, 2023
afcc98b
back out hiveclean
tianluyuan Sep 9, 2023
d361817
Merge branch 'main' into updates_mlpd
tianluyuan Sep 13, 2023
49ddb43
remove check in tests.yml
tianluyuan Sep 13, 2023
21db106
update some of the test reference values
tianluyuan Sep 13, 2023
0c1b494
remove unused npz results. tighten tolerances a bit. update a few mor…
tianluyuan Sep 13, 2023
4e6c21b
update some deprecated I3Tray imports
tianluyuan Sep 13, 2023
4b7cb78
update last test reference
tianluyuan Sep 13, 2023
2c3e540
bump EWMS_PILOT_TASK_TIMEOUT in env-vars.sh
tianluyuan Sep 14, 2023
9d708f2
use default wait for first mesasge
tianluyuan Sep 14, 2023
53935b6
update deprecated from I3Tray
tianluyuan Sep 14, 2023
d92bedf
set the TIMEOUT_FROM_CLEINTS
tianluyuan Sep 14, 2023
178ef91
bump ewms 0.12.1
tianluyuan Sep 15, 2023
4b70107
bump ewms 0.12.2
tianluyuan Sep 15, 2023
630c9a5
<bot> update dependencies*.log files(s)
wipacdevbot Sep 15, 2023
276703f
free disk space
ric-evans Sep 18, 2023
addb35f
<bot> update dependencies*.log files(s)
wipacdevbot Sep 18, 2023
11526cb
try 10GB swap
ric-evans Sep 18, 2023
4fee488
try `actionhippie/swap-space@v1`
ric-evans Sep 18, 2023
092011a
update test values
tianluyuan Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skymap_scanner/client/reco_icetray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from pathlib import Path
from typing import Any, List, Union

from I3Tray import I3Tray # type: ignore[import]
from icecube.icetray import I3Tray # type: ignore[import]
from icecube import ( # type: ignore[import] # noqa: F401
dataio,
frame_object_diff,
Expand Down
2 changes: 1 addition & 1 deletion skymap_scanner/recos/common/pulse_proc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import numpy
from typing import Final, Union, List

from I3Tray import I3Units # type: ignore[import]
from icecube.icetray import I3Units # type: ignore[import]
from icecube import dataclasses # type: ignore[import]


Expand Down
2 changes: 1 addition & 1 deletion skymap_scanner/recos/common/vertex_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import numpy as np

from icecube import dataclasses # type: ignore[import]
from I3Tray import I3Units # type: ignore[import]
from icecube.icetray import I3Units # type: ignore[import]


class VertexGenerator:
Expand Down
2 changes: 1 addition & 1 deletion skymap_scanner/recos/dummy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import time
from typing import List, Final

from I3Tray import I3Units # type: ignore[import]
from icecube.icetray import I3Units # type: ignore[import]
from icecube import ( # type: ignore[import] # noqa: F401
dataclasses,
frame_object_diff,
Expand Down
2 changes: 1 addition & 1 deletion skymap_scanner/recos/millipede_original.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

import numpy

from I3Tray import I3Units
from icecube.icetray import I3Units
from icecube import ( # noqa: F401
VHESelfVeto,
dataclasses,
Expand Down
2 changes: 1 addition & 1 deletion skymap_scanner/recos/millipede_wilks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from typing import Final, List, Tuple

import numpy
from I3Tray import I3Units
from icecube.icetray import I3Units
from icecube import ( # noqa: F401
VHESelfVeto,
dataclasses,
Expand Down
2 changes: 1 addition & 1 deletion skymap_scanner/recos/splinempe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from typing import Final, List


from I3Tray import I3Units # type: ignore[import]
from icecube.icetray import I3Units # type: ignore[import]

# NOTE: icecube module imports are required to make IceTray modules and services available.
from icecube import ( # type: ignore[import] # noqa: F401
Expand Down
2 changes: 1 addition & 1 deletion skymap_scanner/server/start_scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import healpy # type: ignore[import]
import mqclient as mq
import numpy
from I3Tray import I3Units # type: ignore[import]
from icecube.icetray import I3Units # type: ignore[import]
from icecube import ( # type: ignore[import]
astro,
dataclasses,
Expand Down
2 changes: 1 addition & 1 deletion skymap_scanner/utils/prepare_frames.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import os
from typing import Union, List

from I3Tray import I3Tray # type: ignore[import]
from icecube.icetray import I3Tray # type: ignore[import]
from icecube import icetray # type: ignore[import]
from icecube.frame_object_diff.segments import uncompress # type: ignore[import]

Expand Down
74 changes: 37 additions & 37 deletions tests/data/results_json/millipede_wilks/run00136766.evt000007637140.neutrino_1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,75 +9,75 @@
"data": [
[
0,
3168.832935410601,
14904.353056321115,
33112903.854202233
2236.0852490899024,
14379.625917047306,
1831216.1259640679
],
[
1,
2912.783352461024,
0.0,
0.0
2351.607779995118,
156692.36727807156,
156692.36727807156
],
[
2,
1169.8936462249574,
22015.867591402104,
42238.265056230084
966.0506139474076,
13747.178780938762,
14153.211690142853
],
[
3,
2932.6031794590554,
78842.7575318918,
598970.5617964783
2438.662664357953,
90780.1579533567,
90780.1579533567
],
[
4,
2541.9442983636127,
12662.714561419283,
390374.8658668274
1755.4454043709177,
7976.31566038792,
711711.9457682836
],
[
5,
3366.871469488516,
156741.65379912523,
232859.11103577947
2309.2657892016173,
2044446.599015025,
2080560.9446302163
],
[
6,
2835.9840831489305,
30275.157147246835,
66829.25962685159
1894.3263161405857,
36856.52833684265,
80529.74319232801
],
[
7,
3068.2473210643784,
20311.19361235851,
480251.6137087273
2373.6369809442676,
66489.95678217073,
79991.70271357206
],
[
8,
2931.3665841916254,
30714.953099507515,
4053925.680368716
1957.334633180752,
85819.90337002686,
4514311.304182041
],
[
9,
3335.046371824551,
53331.85140614017,
53331.85140614017
2498.435261844039,
231854.39901606322,
231854.39901606322
],
[
10,
3287.252921906848,
76518.33326465017,
180225.90341459936
2040.9405085587157,
0.0,
0.0
],
[
11,
2758.057382030177,
13013.053734304685,
2570155.5410982594
1870.963942484449,
8334.942447299516,
13449898.363858048
]
],
"metadata": {
Expand All @@ -89,4 +89,4 @@
"is_real_event": true
}
}
}
}
8 changes: 4 additions & 4 deletions tests/env-vars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@ set -ex # file is sourced so turn off at end
# export SKYSCAN_OUTPUT_DIR=$PWD/output-dir -- rely on user value
export SKYSCAN_BROKER_CLIENT=rabbitmq
# note=auth env vars are in job(s)
export EWMS_PILOT_TASK_TIMEOUT=600
export EWMS_PILOT_TASK_TIMEOUT=1800
# export SKYSCAN_DEBUG_DIR=debug-pkl-dir -- rely on user value
export SKYSCAN_MQ_TIMEOUT_TO_CLIENTS=5
# export SKYSCAN_MQ_TIMEOUT_FROM_CLIENTS=60 # use default
export SKYSCAN_MQ_CLIENT_TIMEOUT_WAIT_FOR_FIRST_MESSAGE=120
export SKYSCAN_MQ_TIMEOUT_FROM_CLIENTS=1800
# export SKYSCAN_MQ_CLIENT_TIMEOUT_WAIT_FOR_FIRST_MESSAGE=120
Comment on lines 7 to +12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with most of these env values. However, do we expect any reco to take 30 mins?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully not, but before it was using the default which was actually 3 days.

export SKYSCAN_DOCKER_PULL_ALWAYS=0
export SKYSCAN_DOCKER_IMAGE_TAG=local
export SKYSCAN_MINI_TEST='yes'
export SKYSCAN_LOG=DEBUG
export SKYSCAN_LOG_THIRD_PARTY=INFO
export CLIENT_STARTER_WAIT_FOR_STARTUP_JSON=120

set +ex
set +ex