Skip to content

Commit

Permalink
add missing --reco-algo to single-pixel test & make required
Browse files Browse the repository at this point in the history
  • Loading branch information
ric-evans committed Sep 21, 2023
1 parent 81e6aed commit 9d982a6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,7 @@ jobs:
icecube/skymap_scanner:local \
python -m skymap_scanner.client.reco_icetray \
--in-pkl /local/pkls/in.pkl \
--reco-algo ${{ matrix.reco_algo }} \
--gcdqp-packet-json /local/pkls/GCDQp_packet.json \
--baseline-gcd-file $(jq -r '.baseline_GCD_file' tests/data/reco_pixel_pkls/${{ matrix.reco_algo }}/${{ matrix.dir }}/startup.json) \
--out-pkl /local/pkls/out.pkl
Expand Down
3 changes: 2 additions & 1 deletion skymap_scanner/client/reco_icetray.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from pathlib import Path
from typing import Any, List, Union

from icecube.icetray import I3Tray # type: ignore[import]
from icecube import ( # type: ignore[import] # noqa: F401
dataio,
frame_object_diff,
Expand All @@ -20,6 +19,7 @@
photonics_service,
)
from icecube.frame_object_diff.segments import uncompress # type: ignore[import]
from icecube.icetray import I3Tray # type: ignore[import]
from wipac_dev_tools import argparse_tools, logging_tools

from .. import config as cfg
Expand Down Expand Up @@ -244,6 +244,7 @@ def main() -> None:
# "physics" args
parser.add_argument(
"--reco-algo",
required=True,
choices=recos.get_all_reco_algos(),
help="The reconstruction algorithm to use",
)
Expand Down

0 comments on commit 9d982a6

Please sign in to comment.