Update _icetop_weighter.py #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load all columns before creating the generation surfaces. This makes the loading faster, because the columns don't have to be loaded and converted in every repetition of the for loop
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 807 815 +8
=========================================
+ Hits 807 815 +8 ☔ View full report in Codecov by Sentry. |
removed whitespaces in empty line
for more information, see https://pre-commit.ci
|
Thanks for submitting this patch. This change might conflict with a patch i have that is still in progress for the much requested feature of support for i3files. So i will hold off on this until we can do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load all columns before creating the generation surfaces. This makes the loading faster, because the h5 table columns don't have to be loaded and converted in every repetition of the for loop