-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the genie weighter #39
Conversation
Test Results 6 files ±0 6 suites ±0 3m 7s ⏱️ -1s Results for commit 35fddd5. ± Comparison against base commit b4a664f. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 749 755 +6
=========================================
+ Hits 749 755 +6 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Apparently the genie weighting never worked since it was missing the cos_zen variable. This PR adds that in so that simweights works for genie-reader files. There's also an upper limit requirement added for numpy since nuflux won't accept numpy2 yet. That can be removed if needed.
A PR for icetray/genie-reader (icecube/icetray#3607) scales the generation volume based on the energy of the most energetic daughter muon. I'll be adding the necessary bits here to account for that as well.