-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cr flux 4comp fix #28
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
===========================================
- Coverage 100.00% 99.86% -0.14%
===========================================
Files 12 12
Lines 739 747 +8
===========================================
+ Hits 739 746 +7
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
@ athakuri22, Thanks for submitting a PR, the code you submitted looks good. But there a few things you need to do before I can merge this PR. Please read the CONTRIBUTING guide. Specifically make sure all of the pre-commits pass as well as adding data to flux_values.json for the two flux models you added and push the changes to this branch. |
for more information, see https://pre-commit.ci
To get rid of the pylint error you can add |
|
Thanks for the update. You still need to add tests for GlobalFitGST_IT and GlobalSplineFit_IT to tests/test_fluxes.py so the data you added to flux_values.json actually gets used |
also you can ignore that failure from (3.11, macos-12). that looks like nonsense from pytables |
it looks like you put the wrong values in flux_values.json for GlobalSplineFit_IT |
Yes, you are right. |
closes #24 |
adding 4 component fluxes for GST and GSF.