Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cr flux 4comp fix #28

Merged
merged 13 commits into from
Jan 25, 2024
Merged

Cr flux 4comp fix #28

merged 13 commits into from
Jan 25, 2024

Conversation

athakuri22
Copy link
Contributor

adding 4 component fluxes for GST and GSF.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (38261e3) 100.00% compared to head (0b15640) 99.86%.
Report is 7 commits behind head on main.

❗ Current head 0b15640 differs from pull request most recent head 069df80. Consider uploading reports for the commit 069df80 to get more accurate results

Files Patch % Lines
src/simweights/_fluxes.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #28      +/-   ##
===========================================
- Coverage   100.00%   99.86%   -0.14%     
===========================================
  Files           12       12              
  Lines          739      747       +8     
===========================================
+ Hits           739      746       +7     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kjmeagher
Copy link
Member

@ athakuri22, Thanks for submitting a PR, the code you submitted looks good. But there a few things you need to do before I can merge this PR. Please read the CONTRIBUTING guide. Specifically make sure all of the pre-commits pass as well as adding data to flux_values.json for the two flux models you added and push the changes to this branch.

@kjmeagher
Copy link
Member

To get rid of the pylint error you can add #pylint: disable=invalid-name to the line where the class is defined. We already have fluxes with _IT suffixes designated icetop and GlobalFitGSTIT would be worse. You also need to add the new fluxes to__init__.py so people can import them and add them to test_fluxes.py so they are tested

@athakuri22
Copy link
Contributor Author

#pylint: disable=invalid-name worked to get rid of pylint error.
I also added the new fluxes to __init__.py
Thank you.

@kjmeagher
Copy link
Member

Thanks for the update. You still need to add tests for GlobalFitGST_IT and GlobalSplineFit_IT to tests/test_fluxes.py so the data you added to flux_values.json actually gets used

@kjmeagher
Copy link
Member

also you can ignore that failure from (3.11, macos-12). that looks like nonsense from pytables

@kjmeagher
Copy link
Member

it looks like you put the wrong values in flux_values.json for GlobalSplineFit_IT

@athakuri22
Copy link
Contributor Author

Yes, you are right. GlobalSplineFit_IT on flux_values.json was wrong.
I have corrected that now. Thank you.

@kjmeagher kjmeagher merged commit 01198a9 into main Jan 25, 2024
8 of 9 checks passed
@kjmeagher kjmeagher deleted the cr_flux_4comp_fix branch January 25, 2024 15:06
@kjmeagher
Copy link
Member

closes #24

@kjmeagher kjmeagher linked an issue Jan 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IT 4-component fluxes for GST and GSF model
2 participants