icetop effectivearea fix #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Remove unnecessary debug output
for more information, see https://pre-commit.ci
It got anoying waiting for all of them to finis
use less systems for CI (Move Kevin's one commit from Uppercase branch into Lowercase branch)
…s will break a lot of things, but it's just temporary)
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
matthiasplum
force-pushed
the
icetop_effectivearea_fix
branch
from
6d688be to
6d583de
Compare
[email protected]:icecube/simweights.git into icetop_effectivearea_fix
matthiasplum
added a commit
that referenced
this pull request
Oct 23, 2023
kjmeagher
pushed a commit
that referenced
this pull request
Oct 31, 2023
* Second try of fixing #14 started from a clean branch * possible fix for the failing tests and removal of unnecessary object * Update changelog with additional information for IceTop fix * Update IceTop documentation with effective area information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at this pull request, after the accidental "upper-case I / lower-case I" branch confusion. Let's all commit to this one, to get it working!