Skip to content

Commit

Permalink
updates, see changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
gbicann committed Oct 11, 2024
1 parent f2c3760 commit 349d13c
Show file tree
Hide file tree
Showing 6 changed files with 102 additions and 9 deletions.
35 changes: 35 additions & 0 deletions ChangeLog.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,38 @@
2024-10-16:
- |
Updated the test procecdure for [epp-19](#Test-Case-epp-19) so that the
authInfo code is set during an `<update>` rather than `<create>`, to account
for servers that implement RFC 9154 and reject non-empty authInfo elements
during `<create>` commands. Also added the
[`EPP_TRANSFER_SERVER_REJECTS_SECURE_AUTHINFO`](#Error-EPP_TRANSFER_SERVER_REJECTS_SECURE_AUTHINFO)
error code for when the server rejects an authInfo code that it should
accept.
- |
Fix typo in [idn-01](#Test-Case-idn-01) that made the description of the
rules for variants logically incoherent.
- |
Added
[`RDE_DOMAIN_HAS_MISSING_CONTACT`](#Error-RDE_DOMAIN_HAS_MISSING_CONTACT)
and
[`RDE_DOMAIN_HAS_MISSING_NAMESERVER`](#Error-RDE_DOMAIN_HAS_MISSING_NAMESERVER)
to [rde-07](#Test-case-rde-07).
- |
Fixed the description of
[`RDE_DOMAIN_HAS_MISSING_REGISTRANT`](#Error-RDE_DOMAIN_HAS_MISSING_REGISTRANT).
- Clarified that domain and host names, and domain, host and
contact ROIDs must be unique. Added the
[`RDE_DOMAIN_HAS_NON_UNIQUE_NAME`](#Error-RDE_DOMAIN_HAS_NON_UNIQUE_NAME),
[`RDE_HOST_HAS_NON_UNIQUE_NAME`](#Error-RDE_HOST_HAS_NON_UNIQUE_NAME),
[`RDE_DOMAIN_HAS_NON_UNIQUE_ROID`](#Error-RDE_DOMAIN_HAS_NON_UNIQUE_ROID),
[`RDE_HOST_HAS_NON_UNIQUE_ROID`](#Error-RDE_HOST_HAS_NON_UNIQUE_ROID) and
[`RDE_CONTACT_HAS_NON_UNIQUE_ROID`](#Error-RDE_CONTACT_HAS_NON_UNIQUE_ROID)
error codes as needed to [rde-08](#Test-Case-rde-08),
[rde-09](#Test-Case-rde-09) and
[rde-10](#Test-Case-rde-10).

2024-10-09:
- Miscellaneous minor fixes.

2024-10-02:
- Miscellaneous minor fixes.
- |
Expand Down
16 changes: 11 additions & 5 deletions inc/epp/cases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -481,9 +481,9 @@ epp-10:
Summary: Contact <delete> command test (if applicable for the registry type)
Maturity: GAMMA
Description: |
This test will perform `<delete>` commands on the objects created during
`epp-24` and will confirm that the server accepts the `<delete>` command
with a `1xxx` response code.
This test will perform `<delete>` commands on contact objects, and will
confirm that the server accepts the `<delete>` command with a `1xxx`
response code.
If the `general.registryDataModel` input parameter is `minimum`, this
test will be skipped. Otherwise, this client will select the appropriate
Expand Down Expand Up @@ -873,9 +873,13 @@ epp-19:
transfer.
The client will create a domain name, and any contact and/or host objects,
as required. If the server implements [RFC
as required.
The client will then perform an `<update>` command to set an authInfo code.
If the server implements [RFC
9154](https://www.rfc-editor.org/rfc/rfc9154.html), it **MUST** reject the
`<create>` command if the authInfo code is insufficently secure.
`<update>` command if the authInfo code is insufficently secure.
Then, using a second set of credentials, the client will connect to the
EPP server and authenticate, submit `<transfer>` commands, and validate
Expand Down Expand Up @@ -917,6 +921,7 @@ epp-19:
- EPP_SCHEMA_VALIDATION_ERROR
- EPP_LOGIN_ERROR
- EPP_TRANSFER_SERVER_ACCEPTS_INSECURE_AUTHINFO
- EPP_TRANSFER_SERVER_REJECTS_SECURE_AUTHINFO
- EPP_TRANSFER_SERVER_ACCEPTS_INCORRECT_AUTHINFO
- EPP_TRANSFER_SERVER_ACCEPTS_INVALID_PERIOD
- EPP_TRANSFER_INFO_RESPONSE_MISSING_OR_INVALID_STATUS_CODE
Expand Down Expand Up @@ -1101,3 +1106,4 @@ epp-24:
- EPP_LOGIN_ERROR
- EPP_HOST_DELETE_INFO_RESPONSE_OBJECT_STILL_EXISTS
- EPP_GENERIC_COMMAND_ERROR
- EPP_UNEXPECTED_COMMAND_FAILURE
8 changes: 8 additions & 0 deletions inc/epp/errors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -923,6 +923,14 @@ EPP_TRANSFER_SERVER_ACCEPTS_INSECURE_AUTHINFO:
`<update>` command that specified an authInfo code with insufficient
entropy.
EPP_TRANSFER_SERVER_REJECTS_SECURE_AUTHINFO:
Severity: ERROR
Description: |
An EPP server implementing Secure Authorization Information for Transfer
([RFC 9154](https://www.rfc-editor.org/rfc/rfc9154.html)) rejected an
`<update>` command that specified an authInfo code with at least as much
entropy as specified in Section 4.1 of that RFC (that is, 128 bits).
EPP_TRANSFER_SERVER_ACCEPTS_INVALID_PERIOD:
Severity: ERROR
Description: |
Expand Down
2 changes: 1 addition & 1 deletion inc/idn/cases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ idn-01:
generated, The client will also ensure that the EPP server properly
implements that policy: that is, variant domains must (a) be blocked, or (b)
only be available for registration by (i) the same registrant, or (ii) if
the TLD uses the minimal public data set, the same registrant.
the TLD uses the minimal public data set, the same registrar.
Errors:
- EPP_DNS_RESOLUTION_ERROR
- EPP_LOGIN_ERROR
Expand Down
11 changes: 9 additions & 2 deletions inc/rde/cases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,16 @@ rde-07:
`id` property of one of the IDN table objects in the deposit.
Errors:
- RDE_DOMAIN_HAS_INVALID_NAME
- RDE_DOMAIN_HAS_NON_UNIQUE_NAME
- RDE_DOMAIN_HAS_MISSING_ROID
- RDE_DOMAIN_HAS_INVALID_ROID
- RDE_DOMAIN_HAS_NON_UNIQUE_ROID
- RDE_DOMAIN_HAS_MISSING_STATUS
- RDE_DOMAIN_HAS_INVALID_STATUS
- RDE_DOMAIN_HAS_MISSING_REGISTRANT
- RDE_DOMAIN_HAS_INVALID_REGISTRANT
- RDE_DOMAIN_HAS_MISSING_CONTACT
- RDE_DOMAIN_HAS_MISSING_NAMESERVER
- RDE_DOMAIN_HAS_MISSING_CLID
- RDE_DOMAIN_HAS_INVALID_CLID
- RDE_DOMAIN_HAS_MISSING_CRDATE
Expand All @@ -162,7 +166,7 @@ rde-08:
The required properties are:
* `<host:name>` (which **MUST** be unique)
* `<host:roid>` (which **MUST** comply with the specification in [Section
* `<host:roid>` (which **MUST** be unique and **MUST** comply with the specification in [Section
2.8 of RFC 5730](https://www.rfc-editor.org/rfc/rfc5730#section-2.8)
and contain a repository ID that is registered in the [EPP Repository
Identifiers
Expand All @@ -179,8 +183,10 @@ rde-08:
be present in the deposit.
Errors:
- RDE_HOST_HAS_INVALID_NAME
- RDE_HOST_HAS_NON_UNIQUE_NAME
- RDE_HOST_HAS_MISSING_ROID
- RDE_HOST_HAS_INVALID_ROID
- RDE_HOST_HAS_NON_UNIQUE_ROID
- RDE_HOST_HAS_MISSING_STATUS
- RDE_HOST_HAS_INVALID_STATUS
- RDE_HOST_HAS_MISSING_IP_ADDRESS
Expand All @@ -200,7 +206,7 @@ rde-09:
`minimum`, then this test will be skipped.
* The value of the `<contact:id>` element **MUST** be unique in the deposit;
* The value of the `<contact:roid>` (which **MUST** comply with the
* The value of the `<contact:roid>` (which **MUST** be unique and **MUST** comply with the
specification in [Section 2.8 of RFC 5730](https://www.rfc-editor.org/rfc/rfc5730#section-2.8)
and contain a repository ID that is registered in the [EPP Repository
Identifiers
Expand All @@ -219,6 +225,7 @@ rde-09:
Errors:
- RDE_CONTACT_HAS_NON_UNIQUE_ID
- RDE_CONTACT_HAS_INVALID_ROID
- RDE_CONTACT_HAS_NON_UNIQUE_ROID
- RDE_CONTACT_HAS_MULTIPLE_POSTALINFO_TYPES
- RDE_CONTACT_HAS_INVALID_CC
- RDE_CONTACT_HAS_INVALID_EMAIL
Expand Down
39 changes: 38 additions & 1 deletion inc/rde/errors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ RDE_DOMAIN_HAS_MISSING_EXDATE:
RDE_DOMAIN_HAS_MISSING_REGISTRANT:
Severity: ERROR
Description: |
One or more domain objects do not have a `<registrant>` element.
One or more domain objects have a `<registrant>` element which is not
present in the deposit.
RDE_DOMAIN_HAS_MISSING_ROID:
Severity: ERROR
Expand Down Expand Up @@ -305,3 +306,39 @@ RDE_XML_PARSE_ERROR:
Description: |
The XML in the deposit file is not well-formed.
RDE_DOMAIN_HAS_MISSING_CONTACT:
Severity: ERROR
Description: |
One or more domain objects have a `<contact>` element which is not
present in the deposit.
RDE_DOMAIN_HAS_MISSING_NAMESERVER:
Severity: ERROR
Description: |
One or more domain objects have a `<hostObj>` element which is not
present in the deposit.
RDE_DOMAIN_HAS_NON_UNIQUE_NAME:
Severity: ERROR
Description: |
One or more domain objects have the same `<name>` element.
RDE_HOST_HAS_NON_UNIQUE_NAME:
Severity: ERROR
Description: |
One or more host objects have the same `<name>` element.
RDE_DOMAIN_HAS_NON_UNIQUE_ROID:
Severity: ERROR
Description:
One or more domain objects have the same `<roid>` element.

RDE_HOST_HAS_NON_UNIQUE_ROID:
Severity: ERROR
Description:
One or more host objects have the same `<roid>` element.

RDE_CONTACT_HAS_NON_UNIQUE_ROID:
Severity: ERROR
Description:
One or more contact objects have the same `<roid>` element.

0 comments on commit 349d13c

Please sign in to comment.