Enhanced Occurence Comparison for GetOccurences #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…que identifier property in the Occurence object. Updated the Occurence object to use the UID in the Equals and GetHashCode methods to better differentiate occurences from one another. Created a test with some example data.
|
I've found the same problem with GetOccurrences. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the IRecurrable interface with IUniqueComponent. Update Occurence objects Equals and GetHashCode methods to leverage the UID property exposed on the Source property so the comparison routine in GetOccurences can distinguish between Occurences that look equal but have different underlying event data.