Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDK11 FIPS140-3 weak profile to weekly config #255

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

annaibm
Copy link

@annaibm annaibm commented Nov 20, 2024

  • Add 'fips140_3_OpenJCEPlusFIPS' to following test targets in weekly:
    • extended.functional
    • sanity.openjdk
    • extended.openjdk
    • sanity.jck
    • extended.jck
    • special.jck
  • Add the test targets to run on platforms : ppc64_aix, ppc64le_linux,
    s390x_linux, x86-64_linux, x86-64_windows

related: #106

@annaibm annaibm marked this pull request as draft November 20, 2024 18:51
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@annaibm annaibm changed the title Add FIPS 140-2 tests to nightly/weekly configuration Add FIPS140-3 weak profile to weekly config Nov 22, 2024
'sanity.openjdk.fips140_3_OpenJCEPlusFIPS',
'extended.openjdk.fips140_3_OpenJCEPlusFIPS'
]
],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you overwrite the default, you must provide the full list, not just FIPS targets.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annaibm annaibm force-pushed the addTestFIPS branch 3 times, most recently from 0072e25 to 79603fe Compare November 25, 2024 16:16
@annaibm annaibm requested a review from llxia November 25, 2024 16:17
- Add 'fips140_3_OpenJCEPlusFIPS' to following test targets in weekly:
  - extended.functional
  - sanity.openjdk
  - extended.openjdk
  - sanity.jck
  - extended.jck
  - special.jck
- Add the test targets to run on platforms : ppc64_aix, ppc64le_linux,
s390x_linux, x86-64_linux, x86-64_windows

related: https://github.ibm.com/runtimes/automation/issues/106

Signed-off-by: Anna Babu Palathingal <[email protected]>
Copy link

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annaibm annaibm marked this pull request as ready for review November 25, 2024 19:33
@llxia llxia merged commit f819e7d into ibmruntimes:ibm Nov 25, 2024
5 checks passed
@llxia llxia changed the title Add FIPS140-3 weak profile to weekly config Add JDK11 FIPS140-3 weak profile to weekly config Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants