Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle OpenJCEPlus and get GSKit binaries from Artifactory #194

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

KostasTsiounis
Copy link

A new flag is added to the DEFAULTS_JSON struct to allow for bundling OpenJCEPlus with Semeru. Said flag is then potentially propagated to the subsequent scripts.

The appropriate credentials are, also, used to allow for the required downloading of the GSKit binaries.

Signed-off by: Kostas Tsiounis [email protected]

Copy link

github-actions bot commented Jan 8, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor nit pick, I think this should work as is 🤞 .

pipelines/build/common/openjdk_build_pipeline.groovy Outdated Show resolved Hide resolved
@AdamBrousseau
Copy link

Will wait on ibmruntimes/temurin-build#101 to be ready and merge together.

@AdamBrousseau AdamBrousseau merged commit f237938 into ibmruntimes:ibm Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants