Add dockerCredential for jdk8 plinux and zlinux #190
Conversation
LongyuZhang
commented
Nov 30, 2023
LongyuZhang
commented
- Since sanity.external for jdk 8 enabled on these platforms, need to add dockerCredential for them too
- The dockerhub login will solve the pull limit reached issue
- Similar PR for jdk 11 & 17: https://github.com/ibmruntimes/ci-jenkins-pipelines/pull/185/files
- Related Issue: github_ibm/runtimes/backlog/issues/1262
- Since sanity.external for jdk 8 enbaled on these platforms, need to add dockerCredential for them too - The dockerhub login will solve the pull limit reached issue Signed-off-by: LongyuZhang <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
|
@AdamBrousseau could you review it? Thanks. |
