Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set programmatically enableInstallers and enableSigner flags #17

Open
wants to merge 1 commit into
base: ibm
Choose a base branch
from

Conversation

vsebe
Copy link

@vsebe vsebe commented Sep 22, 2021

Remove enableInstallers and enableSigner hard-coded values in job
regenerator. Infer values from defaults.json.
Disable installers by default.

Signed-off-by: Violeta Sebe [email protected]

Remove enableInstallers and enableSigner hard-coded values in job
regenerator. Infer values from defaults.json.
Disable installers by default.

Signed-off-by: Violeta Sebe <[email protected]>
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

@vsebe
Copy link
Author

vsebe commented Sep 22, 2021

@AdamBrousseau pls review, thx!

Copy link

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be delivered straight to Adopt?

@AdamBrousseau AdamBrousseau force-pushed the ibm branch 3 times, most recently from 7eaba31 to 5e9988d Compare October 6, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants