Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpheader: Add default serial number in the header #74

Open
wants to merge 1 commit into
base: 1110
Choose a base branch
from

Conversation

gcpin
Copy link

@gcpin gcpin commented Nov 5, 2024

Whenever the serialNo is empty, use a default serial number (all zeroes) so that scripts/apps that decode the dump header would not throw errors.

Verified that the default serial number is utilized.

Change-Id: I0d9a8cc9e257ed0a852aaca5e6cb0c1833abd41e

@jenkins-openbmc-ibm
Copy link

Can one of the admins verify this patch?

@gcpin gcpin force-pushed the serialno_defect branch 2 times, most recently from 0a094e7 to cfd006c Compare November 9, 2024 12:41
Whenever the serialNo is empty, use a default serial
number (all zeroes) so that scripts/apps that decode
the dump header would not throw errors.

Use fetch_serial_number() so that default serialNo
gets populated whenever the serialNo is empty.

Verified that the default serial number is utilized.

Change-Id: I0d9a8cc9e257ed0a852aaca5e6cb0c1833abd41e
Signed-off-by: Gopichand Paturi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants