Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airpn v1 110624 rebase #73

Open
wants to merge 30 commits into
base: airpn-v1
Choose a base branch
from

Conversation

geissonator
Copy link
Contributor

Rebase with upstream

xt830919 and others added 30 commits October 4, 2024 01:29
Set fail safe percent to 80% for fan sensors so that pid-control service
would set fan PWM to 80% when one of the fan failed.

Note: Need to apply Gerrit 67566 before adding this change.

Tested:
Tested with patch of Gerrit 67566 and checked that the fan PWM would be
set to 80% when one fan failed.

Change-Id: I38acd26f2610ed0ae9dd95fc2130b124383b0be1
Signed-off-by: Ricky CX Wu <[email protected]>
Based on DVT test result from thermal team, the threshold of
temperature sensors on spider board and fan sensors need to be
updated due to low margin.

Change-Id: I4fa2cd66f1da1ee507f2951eea45dbfcf2bf062d
Signed-off-by: Ricky CX Wu <[email protected]>
Correct the PDB HSC power and current error values of the LTC4287 to 2%.

Change-Id: I2ab07ca50836accce261819a45168b73fab39f64
Signed-off-by: Peter Yin <[email protected]>
PSUSensor now supports a new sensor type named smpro_hwmon and the
sensor can report more sensors inside its sysfs. This commit extends the
properties  so the sensor can be configured in Entity-Manager with full
support for the component sensors.

Tested: on Mt.Jade platform with config "Type": "smpro_hwmon" and
necessary _Min, _Max, _Name, _Scale configs
=> The CI build passes and the sensor can be created successfully on
D-Bus.

Signed-off-by: Chau Ly <[email protected]>
Change-Id: Ica45569eb349169efa3032267b4bfd4368e7aadd
This commit adds 2 smpro_hwmon sensors for Mt.Jade platform
configuration.

Signed-off-by: Chau Ly <[email protected]>
Change-Id: I84ca6f03d3bf8015ce06c7c730c3261a94ca4006
Update fan control configs according to the test result from thermal
team.

Change-Id: I57bea4362f3e00a50ca3aaaf6706ea5167d9489a
Signed-off-by: Ricky CX Wu <[email protected]>
Correct the MB HSC power and current error values of
the MP5990 to 2%.

Change-Id: Ica792cf2eb37a57b1358f2e942e1cb90fb0a426c
Signed-off-by: Peter Yin <[email protected]>
`MGNT_P5V_USB_VOLT_V`   Index 7 change to Index 4
`MGNT_P1V2_VOLT_V`      Index 4 change to Index 5
`MGNT_P3V_BAT_VOLT_V`   Index 5 change to Index 6
`MGNT_P1V07_BMC_VOLT_V` Index 6 change to Index 7

Tested:
```
root@bmc:~# busctl get-property xyz.openbmc_project.ADCSensor
/xyz/openbmc_project/sensors/voltage/MGNT_P12V_VOLT_V
xyz.openbmc_project.Sensor.Value Value
d 12.0018
root@bmc:~# busctl get-property
xyz.openbmc_project.ADCSensor
/xyz/openbmc_project/sensors/voltage/MGNT_P1V07_BMC_VOLT_V
xyz.openbmc_project.Sensor.Value Value
d 1.065
root@bmc:~# busctl get-property xyz.openbmc_project.ADCSensor
/xyz/openbmc_project/sensors/voltage/MGNT_P1V2_VOLT_V
xyz.openbmc_project.Sensor.Value Value
d 1.191
root@bmc:~# busctl get-property xyz.openbmc_project.ADCSensor
/xyz/openbmc_project/sensors/voltage/MGNT_P2V5_VOLT_V
xyz.openbmc_project.Sensor.Value Value
d 2.4982
root@bmc:~# busctl get-property xyz.openbmc_project.ADCSensor
/xyz/openbmc_project/sensors/voltage/MGNT_P3V3_VOLT_V
xyz.openbmc_project.Sensor.Value Value
d 3.2798
root@bmc:~# busctl get-property xyz.openbmc_project.ADCSensor
/xyz/openbmc_project/sensors/voltage/MGNT_P3V_BAT_VOLT_V
xyz.openbmc_project.Sensor.Value Value
d 3.0363
root@bmc:~# busctl get-property xyz.openbmc_project.ADCSensor
/xyz/openbmc_project/sensors/voltage/MGNT_P5V_USB_VOLT_V
xyz.openbmc_project.Sensor.Value Value
d 5.0534
root@bmc:~# busctl get-property xyz.openbmc_project.ADCSensor
/xyz/openbmc_project/sensors/voltage/MGNT_P5V_VOLT_V
xyz.openbmc_project.Sensor.Value Value
d 5.0755
```

Change-Id: I9b88f47bfd9b6a1a6d48f0918d6d15d0b720a302
Signed-off-by: Tim Lee <[email protected]>
Adjust fan configs for Calibrated FIO temperature since the max steps of
stepwise reading and output are 20.

Tested:
Checked the phosphor-pid-control service could start normally.

Change-Id: I88aff226010d625e696e3530f59a05f0af67e119
Signed-off-by: Ricky CX Wu <[email protected]>
Revise the HSC calibration formula for the DVT system.

Change-Id: Ifa458da69fbc29db01b6467af1eedb6a86f7fc34
Signed-off-by: Yang Chen <[email protected]>
Add a Motherboard interface on the CMM board.

Change-Id: I54bae0ed5e476d49806f182bcbb9b12509f44bd9
Signed-off-by: Yang Chen <[email protected]>
Introduce initial configuration files for ventura.

Change-Id: I153472f3917a110981403e690076246faaca0dd3
Signed-off-by: Jason Hsu <[email protected]>
Unify the fru name in the sensor name into uppercase letters

Change-Id: I5588c03f6d60816b6f5d7b6df8bd00f824ac3caa
Signed-off-by: Lora Lin <[email protected]>
Remove threshold of the following sensors since these sensors will be
calibrated in virtual sensor service:
1. MEDUSA_48VHSCX_INPUT_X_PWR_W
2. MEDUSA_48VHSCX_X_CURR_A
3. MEDUSA_MBX_12VHSC_X_CURR_A
4. MEDUSA_MBX_12VHSC_INPUT_X_PWR_W

Change-Id: Idf88528fcef0204bbead73acd098be6be7301014
Signed-off-by: Ricky CX Wu <[email protected]>
This commit adds Entity-Manager configurations for
Ampere's Mt. Jefferson platform.

Signed-off-by: Hieu Huynh <[email protected]>
Change-Id: Ia14b42c03442b601abca5eb73b043033e01c3010
This commit adds DIMM virtual sensors and PowerSupply board
configurations to mtjade.json

Tested: Latest CI build passed

Signed-off-by: Chau Ly <[email protected]>
Change-Id: Ia64ad4e408fa177af3b3790a90966a579fa3a659
Adding configuration file for NVIDIA HMC board.

Tested on Catalina system.

```
root@bmc:~# busctl tree xyz.openbmc_project.EntityManager | grep NVIDIA_HMC
        │ ├─ /xyz/openbmc_project/inventory/system/board/NVIDIA_HMC
        │ │ ├─ /xyz/openbmc_project/inventory/system/board/NVIDIA_HMC/HMC
        │ │ ├─ /xyz/openbmc_project/inventory/system/board/NVIDIA_HMC/NVIDIA_HMC_FRU
```

Signed-off-by: Potin Lai <[email protected]>
Change-Id: I22c48d342c735dc64b6ba067d0f5864694a5848f
Adding configuration file for NVIDIA GB200 module.

Tested on Catalina system.
```
root@bmc:~# busctl tree xyz.openbmc_project.EntityManager | grep NVIDIA_GB200
        │ ├─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_0
        │ │ └─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_0/NVIDIA_GB200_0_FRU
        │ ├─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_1
        │ │ └─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_1/NVIDIA_GB200_1_FRU
```

Signed-off-by: Potin Lai <[email protected]>
Change-Id: I81c8a36e5087b5a9bb5399b9626754bba1a0999b
This commit add Mt.Mitchell's card configurations:
1. PowerSupply board to mtmitchell_mb.json
2. Backplane card to mtmitchell_bp.json
3. Riser card to mtmitchell_riser.json

Test: Latest CI build passed

Signed-off-by: Chau Ly <[email protected]>
Change-Id: Idd8a06262af0c362cc5f76bb36df63303f75f46e
Revise the descriptor part of sensor name to comply naming rule.

Change-Id: I8715e49ef19270089728936a16667163ed522f99
Signed-off-by: Lora Lin <[email protected]>
Adding configuration file for NVIDIA GB200 IO board.

Test results:
```
root@bmc:~# busctl tree xyz.openbmc_project.EntityManager | grep NVIDIA_GB200_IO
        │ ├─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_IO_Board_29
        │ │ ├─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_IO_Board_29/IOB29_NIC0_LOCAL_TEMP_C
        │ │ ├─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_IO_Board_29/IOB29_NIC1_LOCAL_TEMP_C
        │ │ └─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_IO_Board_29/NVIDIA_GB200_IO_Board_29_FRU
        │ └─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_IO_Board_41
        │   ├─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_IO_Board_41/IOB41_NIC0_LOCAL_TEMP_C
        │   ├─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_IO_Board_41/IOB41_NIC1_LOCAL_TEMP_C
        │   └─ /xyz/openbmc_project/inventory/system/board/NVIDIA_GB200_IO_Board_41/NVIDIA_GB200_IO_Board_41_FRU
```

Signed-off-by: Potin Lai <[email protected]>
Change-Id: I9ccd3d58b9ce018b0bc10542041fc7e657c539cb
I assume more reviewers always helpful, especially with HPE
adding components to the Entity-Manager repo

Change-Id: I2fe4647972890f1308ac81ed8fda1aa0384fae64
Signed-off-by: Chris Sides <[email protected]>
A daemon for transferring Viable Product Data (VPD) from device-tree
nodes to D-Bus as described in the design doc @
https://gerrit.openbmc.org/c/openbmc/docs/+/66369

and discussed in this Technical Oversight Forum topic @
openbmc/technical-oversight-forum#38

Tested:
Ensure 'model' and/or 'serial-number' nodes are populated in
/proc/device-tree. Can be hardcoded into platform DTS via
linux-kernel recipe if needed.

'''
After OBMC boot, calling
> busctl introspect xyz.openbmc_project.MachineContext /xyz/openbmc_project/MachineContext

produces the following output:

NAME                                          TYPE      SIGNATURE  RESULT/VALUE  FLAGS
...
xyz.openbmc_project.Inventory.Decorator.Asset interface -          -             -
.BuildDate                                    property  s          ""            emits-change writable
.Manufacturer                                 property  s          ""            emits-change writable
.Model                                        property  s          "hpe,dl360"   emits-change writable
.PartNumber                                   property  s          ""            emits-change writable
.SerialNumber                                 property  s          "t5texpl"     emits-change writable
...

Note: Writing to one of these properties will update the property on D-Bus without affecting the
underlying device-tree node. An 'updated' event will be fired, so Entity-Manager probes monitoring
a given property would recognize the new value and key off it.
'''

Change-Id: Id52d1fc3b26010c864c7e64d3dfdf0a2b5de9294
Signed-off-by: Chris Sides <[email protected]>
During bmc reset stress testing, some sensors occasionally lose
thresholds, and the lost thresholds are not created on DBus.

This is because when EM loads the json file and creates interface,
dbus-sensors may have listened and started to create the sensor just
after the `Type` interface is created but before the threshold
interface is created. This is the sensor interface obtained from EM
and does not include the threshold interface. Therefore, the sensor
displayed on DBus does not have a threshold interface.

This commit changes the order of creating interfaces in EM. The Type
interface should be created after the Threshold interface is created.
This is because for the callback method of dbus-sensors, when the
Type interface is created, it is considered that all configurations
of this sensor have been loaded.

Tested:
The bmc reset stress test did not reproduce this issue.

Signed-off-by: George Liu <[email protected]>
Change-Id: Ia8d9e24a8697992cab13aecb35438f142ed29e67
Revise the threshold value of fan_tach and fan_curr.

Change-Id: I83aad534436da80ad53b60f3341ca08f117cf9d8
Signed-off-by: Yang Chen <[email protected]>
The SSD on HDD board use normal power, so the sensor reading only
available when host powered on.
Add `PowerState` and set on for all INA230 sensors.

Signed-off-by: Potin Lai <[email protected]>
Change-Id: I43c20613cf7712c042ae0fc4aa9ed777ee991b40
This adds PowerSupply configurations to mtjefferson_mb.json.

Tested: Latest CI build passed

Signed-off-by: Hieu Huynh <[email protected]>
Change-Id: Ic4bad4acc14bb64e11ee7f023a6ffd4caec203fb
Add ManagedHost interface to yv4 sentinel dome, which will be
used by bmcweb for system discovery and other dbus operations.

Change-Id: I633722ccfa7d957d976ef7dc37fdda12df35d59e
Signed-off-by: Oliver Brewka <[email protected]>
Some GPIOs do not support event_read method to monitor for value
changes. Added a new MonitorType field to specify if the GPIO
needs to be manually polled to detect presence.
Also added PCIE Switch temperature sensors

Tested:
- Verified no change when MonitorType not specified
- Verified functionality when Polling enum was specified

Change-Id: Ie5e8a2afe43d05192828292b629baade6b0c9c82

Signed-off-by: Chris Cain <[email protected]>
The dual rotor fans are indexed by 1 rotor for each fan, followed by the
second rotor for those fans.

Tested on system1 hw
Before:
    Fan      Rotor     Present    RPM   PWM: %  Target  Zone
    ---     --------   -------   -----  ------  ------  ----
    Fan1    Fan1a_in    true      4102   39.22   100%   0 (CECIO)
    Fan1    Fan1b_in    true      4054
    Fan2    Fan2a_in    true      4032   39.22   100%   0 (CECIO)
    Fan2    Fan2b_in    true      4089
    Fan3    Fan3a_in    true      4040   39.22   100%   0 (CECIO)
    Fan3    Fan3b_in    true         0
    Fan4    Fan4a_in    true         0   39.22   100%   0 (CECIO)
    Fan4    Fan4b_in    true         0
    Fan5    Fan5a_in    true         0   39.22   100%   0 (CECIO)
    Fan5    Fan5b_in    true         0
    Fan6    Fan6_in     false        0   39.22   100%   1 (NVME)
    Fan7    Fan7_in     false        0   39.22   100%   1 (NVME)

After: Fan      Rotor     Present    RPM   PWM: %  Target  Zone
    ---     --------   -------   -----  ------  ------  ----
    Fan1    Fan1a_in    true      3972   39.22   100%   0 (CECIO)
    Fan1    Fan1b_in    true         0
    Fan2    Fan2a_in    true      4002   39.22   100%   0 (CECIO)
    Fan2    Fan2b_in    true         0
    Fan3    Fan3a_in    true      4054   39.22   100%   0 (CECIO)
    Fan3    Fan3b_in    true         0
    Fan4    Fan4a_in    true      4027   39.22   100%   0 (CECIO)
    Fan4    Fan4b_in    true         0
    Fan5    Fan5a_in    true      4054   39.22   100%   0 (CECIO)
    Fan5    Fan5b_in    true         0
    Fan6    Fan6_in     false        0   39.22   100%   1 (NVME)
    Fan7    Fan7_in     false        0   39.22   100%   1 (NVME)
Change-Id: Iee747f9b22099719f5d90296c5154b047b74880c
@geissonator geissonator force-pushed the airpn-v1-110624-rebase branch from 7219fa7 to 0e2d1da Compare November 6, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.