Update to latest gatsby. Include Carbon and theme. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "version": "1.0.0", | ||
| "author": "Robin Wieruch <[email protected]> (https://www.robinwieruch.de/)", | ||
| "repository": "https://github.com/rwieruch/gatsby-mdx-starter-project", | ||
| "name": "gatsby-starter-default", |
There was a problem hiding this comment.
Shouldn't this be gatsby-starter-carbon?
| "gatsby": "^2.0.7", | ||
| "gatsby-image": "^2.0.8", | ||
| "gatsby-link": "^2.0.1", | ||
| "gatsby-mdx": "^0.1.4", |
There was a problem hiding this comment.
I think we want to keep mdx packages - @alisonjoseph ?
There was a problem hiding this comment.
Well it depends, looks like @vpicone goal here was to create a very un-opinionated starter?
There was a problem hiding this comment.
@alisonjoseph yeah that was the motivation. I'm a big fan of MDX but it could be easily added in a couple of lines if the starter user wanted to implement markdown blogging functionality. I could be wrong here but I know I'm personally less inclined to use a starter/boilerplate when it's bogged down with tools I have no intention of using.
|
This PR was moved to #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts from scratch with the most modern Gatsby site starter.
It also adds: Carbon Components React as well as @carbon/themes to get the beautiful green theme going.