Update valhalla.js Graphhopper to V7 #948
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In API version 7 of graphhopper the support for vehicle parameter has been dropped. You have to use the profile parameter. see: https://github.com/graphhopper/graphhopper/blob/master/CHAN GELOG.md
miles-grant-ibigroup
requested changes
May 12, 2023
miles-grant-ibigroup
assigned mvanlaar and miles-grant-ibigroup and unassigned miles-grant-ibigroup
|
Thanks for your work on this! Please let me know when you're ready for this to be reviewed. Don't worry about the e2e tests failing, it's because the PR originates from your repo |
|
You can review it now with the latest code. I change te code in the github online editor. |
miles-grant-ibigroup
requested changes
Sep 12, 2023
Comment on lines
+260
to
+266
| let profilecar = false | ||
| let profileveh = true | ||
| // Only check for definition not the value. | ||
| if (process.env.GRAPH_HOPPER_V7) { | ||
| profilecar = true | ||
| profileveh = false | ||
| } |
There was a problem hiding this comment.
Since the value is always car can we instead adjust params after it is set to either add a profile: car or a vehicle: car depending on the config?
| } | ||
| const locations = points.map(p => (`point=${p.lat},${p.lng}`)).join('&') | ||
| // Avoiding motorways requires a POST request with a formatted body | ||
| const avoidmotorwaysbody = { |
There was a problem hiding this comment.
Can we make this configurable? Also please camel case
Comment on lines
+287
to
+288
| ...(profilecar && { profile: 'car' }), | ||
| ...(profileveh && { vehicle: 'car' }) |
There was a problem hiding this comment.
re-use the dynamic object key from earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Version 7 of graphhopper api no longer supported vehicle, you have to use profile paramter instead.
See: https://github.com/graphhopper/graphhopper/blob/master/CHANGELOG.md