Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7546: Wrong label in User settings - Browsing section for displayed items #74

Merged
merged 1 commit into from
Mar 12, 2024
Merged

IBX-7546: Wrong label in User settings - Browsing section for displayed items #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/bundle/Resources/translations/ibexa_user_settings.en.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,16 @@
<target state="new">Browsing</target>
<note>key: settings.group.browsing.name</note>
</trans-unit>
<trans-unit id="c9a8a7a02d6e5a8526e883fc7a6e3e35f40cf809" resname="settings.group.edit_content.description">
<source>settings.group.edit_content.description</source>
<target state="new"></target>
<note>key: settings.group.edit_content.description</note>
</trans-unit>
<trans-unit id="962f753514ae358c3a7c093f354f213ec553e9b3" resname="settings.group.content_authoring.name">
<source>Content authoring</source>
<target state="new">Content authoring</target>
<note>key: settings.group.content_authoring.name</note>
</trans-unit>
<trans-unit id="c9a8a7a02d6e5a8526e883fc7a6e3e35f40cf809" resname="settings.group.edit_content.description">
<source>settings.group.edit_content.description</source>
<target state="new"></target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is suspicious but master of translation accepts so approve ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a common situation that the description is empty in user settings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most suspicious for me in here is that it changed places (but yeah, I also wondered if it's ok that it's empty)

<note>key: settings.group.edit_content.description</note>
</trans-unit>
<trans-unit id="377f69d650dee0a54486fea8f8a89b82203b7755" resname="settings.group.generic.description">
<source>settings.group.generic.description</source>
<target state="new"></target>
Expand Down Expand Up @@ -127,8 +127,8 @@
<note>key: settings.short_datetime_format.value.title</note>
</trans-unit>
<trans-unit id="18f788ade37f54e5d52f0e3ddacb39a5558190b5" resname="settings.subitems_limit.value.description">
<source>Number of items displayed in the table</source>
<target state="new">Number of items displayed in the table</target>
<source>Number of items displayed in the sub-items</source>
<target state="new">Number of items displayed in the sub-items</target>
<note>key: settings.subitems_limit.value.description</note>
</trans-unit>
<trans-unit id="67329191003095f24d2ca7d2182ecb00d5a85e36" resname="settings.subitems_limit.value.title">
Expand Down
2 changes: 1 addition & 1 deletion src/lib/UserSetting/Setting/SubitemsLimit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ private function getTranslatedName(): string
private function getTranslatedDescription(): string
{
return $this->translator->trans(
/** @Desc("Number of items displayed in the table") */
/** @Desc("Number of items displayed in the sub-items") */
'settings.subitems_limit.value.description',
[],
'ibexa_user_settings'
Expand Down
Loading