Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8119: Upgraded minimum PHP version to 8.3 #69

Merged
merged 3 commits into from
May 24, 2024
Merged

IBX-8119: Upgraded minimum PHP version to 8.3 #69

merged 3 commits into from
May 24, 2024

Conversation

Steveb-p
Copy link
Contributor

🎫 Issue IBX-8119

Description:

This PR bumps the minimum required version of PHP to 8.3.
>=8.3 version constraint is set with expectation of compatibility with version PHP 9.

Additionally, this PR:

  • enforces sorting of packages within require and require-dev sections of composer.json file
  • replaces ~5.0.0@dev declarations with their more development friendly ~5.0.x-dev.
  • adjusts github workflows to match new PHP version
  • updates GH action versions

konradoboza
konradoboza approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 in advance, I guess few quite a few empty lines that will emerge after fixing CS won't change my mind. 😉

@konradoboza konradoboza requested a review from a team May 23, 2024 11:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Steveb-p Steveb-p merged commit 2834e63 into main May 24, 2024
16 checks passed
@Steveb-p Steveb-p deleted the ibx-8119-php-upgrade branch May 24, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ciastektk ciastektk ciastektk approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Steveb-p @adamwojs @ciastektk @konradoboza @alongosz