aftre huddle review - BaseIsContainer

ibexa · Apr 19, 2024 · 040573d · 040573d
1 parent b7ee404
commit 040573d
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 19 deletions.
diff --git a/...on/CriterionVisitor/CommonIsContainer.php → ...mmon/CriterionVisitor/BaseIsContainer.php b/...on/CriterionVisitor/CommonIsContainer.php → ...mmon/CriterionVisitor/BaseIsContainer.php
@@ -4,14 +4,18 @@
  * @copyright Copyright (C) Ibexa AS. All rights reserved.
  * @license For full copyright and license information view LICENSE file distributed with this source code.
  */
+declare(strict_types=1);
+
 namespace Ibexa\Solr\Query\Common\CriterionVisitor;
 
 use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion;
 use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\Operator;
 use Ibexa\Contracts\Solr\Query\CriterionVisitor;
 
-abstract class CommonIsContainer extends CommonCriterionVisitor
+abstract class BaseIsContainer extends CriterionVisitor
 {
+    abstract protected function getTargetField(): string;
+
     public function canVisit(Criterion $criterion): bool
     {
         return $criterion instanceof Criterion\IsContainer && $criterion->operator === Operator::EQ;

diff --git a/src/lib/Query/Common/CriterionVisitor/CommonCriterionVisitor.php b/src/lib/Query/Common/CriterionVisitor/CommonCriterionVisitor.php
diff --git a/src/lib/Query/Content/CriterionVisitor/IsContainer.php b/src/lib/Query/Content/CriterionVisitor/IsContainer.php
@@ -6,9 +6,9 @@
  */
 namespace Ibexa\Solr\Query\Content\CriterionVisitor;
 
-use Ibexa\Solr\Query\Common\CriterionVisitor\CommonIsContainer;
+use Ibexa\Solr\Query\Common\CriterionVisitor\BaseIsContainer;
 
-final class IsContainer extends CommonIsContainer
+final class IsContainer extends BaseIsContainer
 {
     public function getTargetField(): string
     {

diff --git a/src/lib/Query/Location/CriterionVisitor/IsContainer.php b/src/lib/Query/Location/CriterionVisitor/IsContainer.php
@@ -6,9 +6,9 @@
  */
 namespace Ibexa\Solr\Query\Location\CriterionVisitor;
 
-use Ibexa\Solr\Query\Common\CriterionVisitor\CommonIsContainer;
+use Ibexa\Solr\Query\Common\CriterionVisitor\BaseIsContainer;
 
-final class IsContainer extends CommonIsContainer
+final class IsContainer extends BaseIsContainer
 {
     public function getTargetField(): string
     {