Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8534: Change deprecated path to inputUri #139

Merged
merged 4 commits into from
Dec 10, 2024
Merged

IBX-8534: Change deprecated path to inputUri #139

merged 4 commits into from
Dec 10, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Dec 2, 2024

🎫 Issue IBX-8534

Related PRs:

Description:

For QA:

Documentation:

@Steveb-p Steveb-p requested a review from a team December 2, 2024 10:33
@konradoboza konradoboza requested a review from a team December 2, 2024 10:34
alongosz
alongosz reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, I just need a little bit more ensurance to make sure we won't merge this with tmp commits, just to be safe:

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@ViniTou ViniTou changed the title IBX-8534: Change deprecated path to inputUri [TMP] IBX-8534: Change deprecated path to inputUri Dec 2, 2024
@ViniTou ViniTou mentioned this pull request Dec 3, 2024
Merged
@alongosz alongosz requested a review from a team December 4, 2024 11:26
@ViniTou ViniTou force-pushed the ibx-8535-deprecations branch from 087cc64 to a79ed84 Compare December 10, 2024 13:35
@ViniTou ViniTou changed the title [TMP] IBX-8534: Change deprecated path to inputUri IBX-8534: Change deprecated path to inputUri Dec 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ViniTou ViniTou merged commit 7f5fcc5 into main Dec 10, 2024
11 checks passed
@ViniTou ViniTou deleted the ibx-8535-deprecations branch December 10, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@tischsoic tischsoic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ViniTou @Steveb-p @alongosz @konradoboza @tischsoic