Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8535: Dropped deprecated loadRelations usage #137

Merged
merged 6 commits into from
Nov 4, 2024
Merged

IBX-8535: Dropped deprecated loadRelations usage #137

merged 6 commits into from
Nov 4, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Oct 25, 2024 •
edited
Loading

@ViniTou ViniTou force-pushed the ibx-8535-deprecations branch 7 times, most recently from 3e72a07 to 98e6742 Compare October 28, 2024 14:38
@ViniTou ViniTou changed the title IBX-8535: Dropped deprecated loadRelations usage [TMP] IBX-8535: Dropped deprecated loadRelations usage Oct 30, 2024
@ViniTou ViniTou requested a review from a team October 30, 2024 15:27
alongosz
alongosz reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall ok, but remarks from ibexa/core#444 (review) are quite relevant for this.

tests/lib/Server/Output/ValueObjectVisitor/RestExecutedViewTest.php Outdated Show resolved Hide resolved
@alongosz alongosz requested a review from a team October 30, 2024 17:59
@ViniTou ViniTou requested a review from alongosz October 31, 2024 13:00
@alongosz alongosz requested a review from a team November 4, 2024 09:43
konradoboza
konradoboza approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, apart from renaming to RelationListFacadeInterface.

@ViniTou ViniTou force-pushed the ibx-8535-deprecations branch from cb4d4ee to 058b362 Compare November 4, 2024 11:48
@ViniTou ViniTou force-pushed the ibx-8535-deprecations branch from 058b362 to fff7e2c Compare November 4, 2024 12:20
@ViniTou ViniTou changed the title [TMP] IBX-8535: Dropped deprecated loadRelations usage IBX-8535: Dropped deprecated loadRelations usage Nov 4, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.8% Duplication on New Code

See analysis details on SonarCloud

@alongosz
Copy link
Member

alongosz commented Nov 4, 2024

Usage covered by functional tests. Merging.

@alongosz alongosz merged commit 4fce25f into main Nov 4, 2024
10 checks passed
@alongosz alongosz deleted the ibx-8535-deprecations branch November 4, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbialcz tbialcz tbialcz approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@tischsoic tischsoic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ViniTou @alongosz @konradoboza @tbialcz @Steveb-p @tischsoic