IBX-8535: Deprecate RequestParser and implementations #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
force-pushed
the
ibx-8535-deprecate-request-parser
branch
from
73be1d4 to
6aa72e3
Compare
Steveb-p
reviewed
Sep 2, 2024
src/lib/RequestParser.php
Outdated
Comment on lines
12
to
13
| * @deprecated 4.6.11 | ||
| * use \Ibexa\Contracts\Rest\UriParser\UriParserInterface and \Symfony\Component\Routing\RouterInterface instead |
There was a problem hiding this comment.
I think it should be in one line and match our deprecation document:
#VERSION# The "#CLASSNAME#" class is deprecated, will be removed in #VERSION#. Use "#CLASSNAME#" instead.
See https://ibexa.atlassian.net/wiki/spaces/ENG/pages/5799937/PHP+Conventions+Deprecation+standards
konradoboza
approved these changes
Sep 2, 2024
|
alongosz
approved these changes
Sep 4, 2024
adamwojs
approved these changes
Sep 6, 2024
|
You can merge up changes @ViniTou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
During removing deprecated
\Ibexa\Bundle\Rest\RequestParser\Routerit turned out, it does not make much sense to keep interface and other unused implementations.For QA:
Documentation: