-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8825: Added strict_mode
for REST API
#124
Conversation
Quality Gate passedIssues Measures |
strict_mode
for REST APIstrict_mode
for REST API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I would rename it to verbose_mode
maybe or silence_mode: false
. Strict to me isn't that self-explanatory but it's not a blocker.
It follows a similar feature that is coming for Page Builder, and is available in Twig itself. It's Verbosity doesn't really match as we are not adding any additional info that wasn't already there. We're "promoting it" to a real exception. |
@adamwojs I'd need a decision here whether QA should test this or not. It might be quite difficult to test, since it requires some custom field types, and missing a normalizer for it's value. WDYT? |
We can skip QA. It's doesn't affect prod. env. |
Merged up into |
Description:
This PR introduces the concept of
strict_mode
for REST.In
strict_mode
, when REST processing encounters an error/exception that it previously silenced (and usually logged as an error) it will re-throw it.For QA:
Note
This functionality needs to be tested separately on
prod
anddev
application environments.Documentation: