Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8138: [Rector] Applied rules from Symfony 5 Rector set lists #118

Merged
merged 3 commits into from
Aug 29, 2024
Merged

IBX-8138: [Rector] Applied rules from Symfony 5 Rector set lists #118

merged 3 commits into from
Aug 29, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jul 19, 2024 •
edited
Loading

Caution

🎫 Issue IBX-8138

Description:

Applied rules from Symfony 5 Rector set lists.

For QA:

No QA needed. Regression tests should be enough.

Documentation:

This is code refactoring without behavior change. No documentation changes needed.

@alongosz alongosz mentioned this pull request Jul 24, 2024
Merged
@alongosz alongosz force-pushed the ibx-8138-symfony-5-rule-sets branch 2 times, most recently from 7be9dcb to 5dd0089 Compare August 7, 2024 10:19
@alongosz alongosz force-pushed the ibx-8138-symfony-5-rule-sets branch from e8ad2f4 to 7e7e85c Compare August 20, 2024 09:56
@alongosz alongosz mentioned this pull request Aug 20, 2024
Closed
@alongosz alongosz requested review from Steveb-p and a team August 26, 2024 10:25
@alongosz alongosz force-pushed the ibx-8138-symfony-5-rule-sets branch from 7e7e85c to 63f45fd Compare August 28, 2024 19:50
@alongosz alongosz mentioned this pull request Aug 28, 2024
Merged
@alongosz
[Rector] Applied all Symfony 5.x rectors to the production codebase
2b03bf3 
Applied rules:
 * AddParamTypeDeclarationRector
 * AddReturnTypeDeclarationRector
 * LiteralGetToRequestClassConstantRector
 * RenameMethodRector
 * ResponseStatusCodeRector
@alongosz
[Rector][Tests] Applied all Symfony 5.x rectors to the test codebase
b447d3b 
Applied rules:
 * ResponseStatusCodeRector
@alongosz
Dropped obsolete JWTUser class
4c8d47d
@alongosz alongosz force-pushed the ibx-8138-symfony-5-rule-sets branch from 63f45fd to 4c8d47d Compare August 29, 2024 08:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 878881a into main Aug 29, 2024
9 checks passed
@alongosz alongosz deleted the ibx-8138-symfony-5-rule-sets branch August 29, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@tischsoic tischsoic

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alongosz @adamwojs @mikadamczyk @Steveb-p @konradoboza @tischsoic