Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9109: Enabling TypeScript (ts-loader) with Webpack Encore #145

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-145

before executing the recipes.

"@svgr/webpack": "^8.1.0"
"@svgr/webpack": "^8.1.0",
"ts-loader": "^9.5.1",
"ts-config-ibexa": "https://github.com/ibexa/ts-config-ibexa"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should install this package using specific tag (which currently doesn't exist probably), to avoid problems with updating config in the future.

This comment is valid for all other places as well, of course. :)

@lucasOsti lucasOsti force-pushed the IBX-9109-enabling-typescript branch 4 times, most recently from 7623ba9 to 66bde2b Compare November 12, 2024 13:42
@lucasOsti lucasOsti force-pushed the IBX-9109-enabling-typescript branch from eb2b49a to cf0b682 Compare November 20, 2024 08:07
ibexa/oss/5.0/encore/package.json Outdated Show resolved Hide resolved
@lucasOsti lucasOsti requested a review from GrabowskiM November 20, 2024 13:01
@lucasOsti lucasOsti force-pushed the IBX-9109-enabling-typescript branch from 260a44a to 20922a8 Compare November 21, 2024 08:22
@lucasOsti lucasOsti requested a review from dew326 November 21, 2024 12:16
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@dew326 dew326 merged commit a317c26 into master Dec 9, 2024
2 of 3 checks passed
@dew326 dew326 deleted the IBX-9109-enabling-typescript branch December 9, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants