Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated outdated mentions of PHP 5 #87

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Updated outdated mentions of PHP 5 #87

merged 3 commits into from
Dec 27, 2024

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Dec 27, 2024

Removed the outdated mentions of PHP 5.

The socket name is taken from: https://php.watch/articles/php-8.3-install-upgrade-on-debian-ubuntu#sapis

@mnocon mnocon requested review from glye, mateuszbieniek and a team December 27, 2024 08:41
@mateuszbieniek
Copy link
Contributor

mateuszbieniek commented Dec 27, 2024

Hi! Looks good, but...
On my Ubuntu 24.04 the path to the socket looks like this:
/var/run/php/php8.3-fpm.sock
This was the default after running apt install php php-fpm

@mnocon
Copy link
Contributor Author

mnocon commented Dec 27, 2024

Thanks, updated in 89357e8

# the socket file `/var/run/php5-fpm.sock` via local file system and hence run on the same machine.
#SetHandler "proxy:unix:/var/run/php5-fpm.sock|fcgi://localhost/"
# the socket file `/var/run/php/php8.3-fpm.sock` via local file system and hence run on the same machine.
#SetHandler "proxy:unix:/var/run/php/php8.3-fpm.sock|fcgi://localhost/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#SetHandler "proxy:unix:/var/run/php/php8.3-fpm.sock|fcgi://localhost/"
#SetHandler "proxy:unix:/var/run/php/php-fpm.sock|fcgi://localhost/"

everywhere and you're gonna make this future proof without worrying about PHP 10 (internal pun) ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateuszbieniek does this suggestion work for you? Don't want to change after you've already approved 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, just checked and there is indeed php-fpm.sock defaulting to 8.3 in my instance!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh boy, 20 years of using Linux and did not notice that...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved in 9d966e6 , thank you!

@adamwojs adamwojs merged commit 718becb into 4.6 Dec 27, 2024
8 checks passed
@adamwojs adamwojs deleted the update-template branch December 27, 2024 09:39
Copy link
Contributor

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants