-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated outdated mentions of PHP 5 #87
Conversation
Hi! Looks good, but... |
Thanks, updated in 89357e8 |
# the socket file `/var/run/php5-fpm.sock` via local file system and hence run on the same machine. | ||
#SetHandler "proxy:unix:/var/run/php5-fpm.sock|fcgi://localhost/" | ||
# the socket file `/var/run/php/php8.3-fpm.sock` via local file system and hence run on the same machine. | ||
#SetHandler "proxy:unix:/var/run/php/php8.3-fpm.sock|fcgi://localhost/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#SetHandler "proxy:unix:/var/run/php/php8.3-fpm.sock|fcgi://localhost/" | |
#SetHandler "proxy:unix:/var/run/php/php-fpm.sock|fcgi://localhost/" |
everywhere and you're gonna make this future proof without worrying about PHP 10 (internal pun) ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mateuszbieniek does this suggestion work for you? Don't want to change after you've already approved 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah, just checked and there is indeed php-fpm.sock defaulting to 8.3 in my instance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh boy, 20 years of using Linux and did not notice that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improved in 9d966e6 , thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Removed the outdated mentions of PHP 5.
The socket name is taken from: https://php.watch/articles/php-8.3-install-upgrade-on-debian-ubuntu#sapis