Introduced NoConfigResolverParametersInConstructorRule PHPStan custom rule
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
force-pushed
the
added-custom-constructor-phpstan-rule
branch
from
e8f93cc to
f14626c
Compare
konradoboza
changed the title
NoConfigResolverInConstructorRule PHPStan custom ruleNoConfigResolverParametersInConstructorRule PHPStan custom rule
konradoboza
force-pushed
the
added-custom-constructor-phpstan-rule
branch
from
f14626c to
4b474f3
Compare
konradoboza
force-pushed
the
added-custom-constructor-phpstan-rule
branch
3 times, most recently
from
6a530fb to
a955ed4
Compare
konradoboza
force-pushed
the
added-custom-constructor-phpstan-rule
branch
from
a955ed4 to
4c7346d
Compare
Steveb-p
approved these changes
Dec 11, 2024
alongosz
reviewed
Dec 12, 2024
alongosz
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introduced our first custom rule to PHPStan. It guards referring to config resolver parameters in constructor (usage of methods:
hasParameterandgetParameter).Note: I decided to make it
nonIgnorablewhich means it cannot be put into baseline. To me it is should be enforced rather than suggested as SiteAccess scope change might corrupt the actual outcome.composer phpstanwill produce the following:Moreover I provided PHPUnit coverage aligned with recommendations, ref: https://phpstan.org/developing-extensions/testing#custom-rules.
For QA:
Documentation: