IBX-9154: The dropdown for custom class is illegible #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Nov 18, 2024
dew326
approved these changes
Nov 19, 2024
bozatko
approved these changes
Nov 19, 2024
GrabowskiM
approved these changes
Nov 20, 2024
tischsoic
approved these changes
Nov 20, 2024
lucasOsti
force-pushed
the
IBX-9154-The-dropdown-for-custom-class-is-illegible
branch
from
8d5b996 to
409b7a6
Compare
lucasOsti
requested review from
bozatko,
dew326,
GrabowskiM,
adamwojs and
tischsoic
lucasOsti
force-pushed
the
IBX-9154-The-dropdown-for-custom-class-is-illegible
branch
from
409b7a6 to
31958a6
Compare
GrabowskiM
approved these changes
Nov 25, 2024
| @@ -16,6 +17,14 @@ class IbexaAttributesUI extends Plugin { | |||
| this.formView = this.createFormView(); | |||
|
|
|||
| this.showForm = this.showForm.bind(this); | |||
|
|
|||
| let timeoutId = null; | |||
There was a problem hiding this comment.
i think new line? Or not, I'm already totally lost :D
dew326
approved these changes
Nov 26, 2024
bozatko
approved these changes
Nov 26, 2024
|
KamilSznajdrowicz
requested changes
Nov 28, 2024
There was a problem hiding this comment.
After applying the patch to version 4.6.13 in bundle fieldtype-richtext, an error occurs when running the yarn encore dev command:
When opening any article, I cannot type anything into the intro and body fields, and errors appear in the console:
UPDATE: Unfortunately, the Apple patch version (Apple patch 2.0-12u11) I was using is too outdated. It is recommended to use GNU patch instead. I installed the GNU version (gpatch), and the patch works without errors now.
KamilSznajdrowicz
approved these changes
Dec 5, 2024
dew326
deleted the
IBX-9154-The-dropdown-for-custom-class-is-illegible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It was necessary to add a scroll for the custom tags and custom attributes panels. PR also solves
https://issues.ibexa.co/browse/IBX-9233
For QA:
Documentation: