Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TMP] IBX-8470: Upgraded dependencies to symfony 6 #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,19 @@
"require": {
"php": ">=8.3",
"ext-json": "*",
"ibexa/admin-ui": "~5.0.x-dev",
"ibexa/content-forms": "~5.0.x-dev",
"ibexa/core": "~5.0.x-dev",
"ibexa/graphql": "~5.0.x-dev",
"ibexa/rest": "~5.0.x-dev",
"ibexa/admin-ui": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"ibexa/content-forms": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"ibexa/core": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"ibexa/graphql": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"ibexa/rest": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"psr/log": "^1.1",
"symfony/dependency-injection": "^5.0",
"symfony/event-dispatcher": "^5.0",
"symfony/expression-language": "^5.0",
"symfony/framework-bundle": "^5.0",
"symfony/http-kernel": "^5.0",
"symfony/translation": "^5.0",
"symfony/yaml": "^5.0"
"symfony/dependency-injection": "^6.4",
"symfony/event-dispatcher": "^6.4",
"symfony/expression-language": "^6.4",
"symfony/framework-bundle": "^6.4",
"symfony/http-kernel": "^6.4",
"symfony/translation": "^6.4",
"symfony/yaml": "^6.4"
},
"autoload": {
"psr-4": {
Expand All @@ -38,14 +38,14 @@
},
"require-dev": {
"ibexa/code-style": "~2.0.0",
"ibexa/design-engine": "~5.0.x-dev",
"ibexa/doctrine-schema": "~5.0.x-dev",
"ibexa/fieldtype-richtext": "~5.0.x-dev",
"ibexa/http-cache": "~5.0.x-dev",
"ibexa/notifications": "~5.0.x-dev",
"ibexa/design-engine": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"ibexa/doctrine-schema": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"ibexa/fieldtype-richtext": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"ibexa/http-cache": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"ibexa/notifications": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"ibexa/phpstan": "~5.0.0@dev",
"ibexa/search": "~5.0.x-dev",
"ibexa/user": "~5.0.x-dev",
"ibexa/search": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"ibexa/user": "dev-ibx-8470-symfony-6 as 5.0.x-dev",
"phpspec/phpspec": "^7.1",
"phpstan/phpstan": "^2.0",
"phpstan/phpstan-phpunit": "^2.0",
Expand Down
6 changes: 0 additions & 6 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,6 @@ parameters:
count: 1
path: src/lib/Persistence/Legacy/Content/FieldValue/Converter/QueryConverter.php

-
message: '#^Anonymous function should return Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\Content but returns Ibexa\\Contracts\\Core\\Repository\\Values\\ValueObject\.$#'
identifier: return.type
count: 1
path: src/lib/QueryFieldService.php

-
message: '#^Method Ibexa\\FieldTypeQuery\\QueryFieldService\:\:isExpression\(\) has parameter \$expression with no type specified\.$#'
identifier: missingType.parameter
Expand Down
11 changes: 7 additions & 4 deletions src/lib/ContentView/QueryResultsPagerFantaAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
use Ibexa\Contracts\FieldTypeQuery\QueryFieldServiceInterface;
use Pagerfanta\Adapter\AdapterInterface;

/**
* @implements AdapterInterface<\Ibexa\Contracts\Core\Repository\Values\Content\Content>
*/
final class QueryResultsPagerFantaAdapter implements AdapterInterface
{
/** @var \Ibexa\Contracts\FieldTypeQuery\QueryFieldServiceInterface */
Expand All @@ -32,15 +35,15 @@ public function __construct(
$this->fieldDefinitionIdentifier = $fieldDefinitionIdentifier;
}

public function getNbResults()
public function getNbResults(): int
{
return $this->queryFieldService->countContentItems(
return max($this->queryFieldService->countContentItems(
$this->content,
$this->fieldDefinitionIdentifier
);
), 0);
}

public function getSlice($offset, $length)
public function getSlice($offset, $length): iterable
{
return $this->queryFieldService->loadContentItemsSlice(
$this->content,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
use Ibexa\Contracts\FieldTypeQuery\QueryFieldLocationService;
use Pagerfanta\Adapter\AdapterInterface;

/**
* @implements AdapterInterface<\Ibexa\Contracts\Core\Repository\Values\Content\Content>
*/
final class QueryResultsWithLocationPagerFantaAdapter implements AdapterInterface
{
/** @var \Ibexa\Contracts\FieldTypeQuery\QueryFieldLocationService */
Expand All @@ -32,15 +35,15 @@ public function __construct(
$this->fieldDefinitionIdentifier = $fieldDefinitionIdentifier;
}

public function getNbResults()
public function getNbResults(): int
{
return $this->queryFieldService->countContentItemsForLocation(
return max($this->queryFieldService->countContentItemsForLocation(
$this->location,
$this->fieldDefinitionIdentifier
);
), 0);
}

public function getSlice($offset, $length)
public function getSlice($offset, $length): iterable
{
return $this->queryFieldService->loadContentItemsSliceForLocation(
$this->location,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/GraphQL/QueryFieldResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public function resolveQueryField(Field $field, Content $content): iterable
}

/**
* @return \GraphQL\Executor\Promise\Promise|\Overblog\GraphQLBundle\Relay\Connection\Output\Connection|null
* @return \GraphQL\Executor\Promise\Promise|\Overblog\GraphQLBundle\Relay\Connection\Output\Connection<\Ibexa\Contracts\Core\Repository\Values\Content\Content>|null
*/
public function resolveQueryFieldConnection(Argument $args, ?Field $field, Content $content)
{
Expand Down
Loading