Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "external" icon to links to other domain #324

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Dec 4, 2024

Question Answer
JIRA Ticket N/A
Versions All
Edition All

While the CSS is there, the JS to add the icon wasn't. Piece of code taken from https://github.com/ibexa/documentation-developer/blob/c636be472cab8f702d82f6ce3b0b2273beb6e916/docs/js/custom.js#L109-L113

Previews:

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Added link to this PR in relevant JIRA ticket or code PR

Copy link

sonarqubecloud bot commented Dec 4, 2024

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adriendupuis adriendupuis merged commit 69d5727 into master Dec 5, 2024
6 checks passed
@adriendupuis adriendupuis deleted the external-link-icon branch December 5, 2024 10:35
adriendupuis added a commit that referenced this pull request Dec 5, 2024
adriendupuis added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants