Fixed description of Sales Rep block #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juskora
approved these changes
Jul 11, 2024
| @@ -292,7 +292,7 @@ On the **Properties** tab, set values in the following fields: | |||
|
|
|||
| - **Name** – Enter a name for the page block. | |||
|
|
|||
| On the **Design** tab, in the **View** field, select the layout to be used to present a list of products and submit your changes. | |||
| On the **Design** tab, in the **View** field, select the layout to be used to present the Sales representative's details and submit your changes. | |||
There was a problem hiding this comment.
Suggested change
| On the **Design** tab, in the **View** field, select the layout to be used to present the Sales representative's details and submit your changes. | |
| On the **Design** tab, in the **View** field, select the layout to be used to present the Sales representative's details page and submit your changes. |
There was a problem hiding this comment.
Not sure about this - this is a layout only for the Sales rep block, it doesn't change how the whole page looks - it changes only a small fragment of the page.
Does it change anything or would you still describe it as a page?
There was a problem hiding this comment.
But block is displayed as a section, we can go with the word: view.
There was a problem hiding this comment.
Makes sense, thanks!
mnocon
commented
Jul 11, 2024
|
julitafalcondusza
approved these changes
Jul 12, 2024
mnocon
added a commit
that referenced
this pull request
Jul 15, 2024
* Fixed description of Sales Rep block * Update docs/content_management/block_reference.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sales Rep block displays Sales Rep's details and has nothing to do with products.
Target: master, 4.6
Preview: https://ez-systems-developer-documentation--302.com.readthedocs.build/projects/userguide/en/302/content_management/block_reference/#sales-representative