-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JS files formatting with Prettier #2573
base: master
Are you sure you want to change the base?
Conversation
package.json
Outdated
}, | ||
"prettier": "eslint-config-ibexa/prettier", | ||
"devDependencies": { | ||
"eslint-config-ibexa": "https://github.com/ibexa/eslint-config-ibexa.git#v1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 4.6 we use ~v1.1.1 and in 5.0 we have ~v1.2.0. I'm not sure if you want to have v1.0.0 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped in faf80a2
code_samples/ change report
|
This is extracted from #2537 (suggested by @GrabowskiM )
Target: master, 4.6
Things done - I belive it might be best to review by commits:
While both configs are added, this PR focuses only on Prettier - we might introduce ESLint in the future, we will see
Run Prettier: 0a7d956
Only autogenerated changes here
Removed obsolete files: 4f7291e
The references to these files were removed in https://github.com/ibexa/documentation-developer/pull/1529/files . They still mention
ezplatform-richtext
, so they're clearly outdated.Added a step fixing the code samples by default, same way we have the code style fixed for PHP:
f76c24f
Adjusted highlighting: 49267f3 (thanks to the "report changes to code samples job" 💪 )
Migrated from node-sass to sass: I had trouble installing the packages locally using node-sass as a dependency, the error looked like this:
Migration to
sass
seems to work - I've verified thatyarn sass
still works.Open question: should we include the
yarn.lock
in the repository?