Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4064: Search adjustements #2566

Merged
merged 2 commits into from
Dec 5, 2024
Merged

IBX-4064: Search adjustements #2566

merged 2 commits into from
Dec 5, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Dec 2, 2024 •
edited
Loading

Question Answer
JIRA Ticket IBX-4064
Versions All
Edition All
  • "See all results" → "See more results" Algolia is limited to 1000 results. As I didn't find a way to increase it, the need was discarded as nobody goes to the 1000th result. "See more results" is more adapted to this situation of not showing absolutely all results.
  • Disable keyboard selection, no more result highlight moving on keyboard navigation with arrows. To navigate with keyboard doesn't work as "Enter" key is a shortcut to open the search page instead of the item selected with the keyboard, so, highlight was useless and misleading.

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis mentioned this pull request Dec 2, 2024
Merged
5 tasks
@adriendupuis adriendupuis marked this pull request as ready for review December 4, 2024 16:19
adriendupuis added a commit to ibexa/documentation-user that referenced this pull request Dec 4, 2024
@adriendupuis
custom.js: Apply ibexa/documentation-developer#2566
8af68dc
dabrt
dabrt reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@dabrt dabrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to have an issue with "Show more results" link. Contacted Adrien directly with a recording

@dabrt dabrt self-requested a review December 5, 2024 08:13
@adriendupuis
Copy link
Contributor Author

adriendupuis commented Dec 5, 2024 •
edited
Loading

I seem to have an issue with "Show more results" link. Contacted Adrien directly with a recording

The "See more results" link appears only when there is more than 10 results. If all the results are in the drop-down list, no need to link to a search result screen which pagination will only present one page.

But, it's true that seeing the link blinking while typing could be disturbing. It's worth thinking more about this (a placeholder, an idle delay, …)

@adriendupuis adriendupuis merged commit 33fc6d9 into master Dec 5, 2024
6 checks passed
@adriendupuis adriendupuis deleted the search-fix branch December 5, 2024 09:13
adriendupuis added a commit that referenced this pull request Dec 5, 2024
@adriendupuis
IBX-4064: Search adjustements (#2566)
9d3db82 
* custom.js: "See all results" → "See more results"
* custom.js: No search result highlight on keyboard navigation

(cherry picked from commit 33fc6d9)
adriendupuis added a commit that referenced this pull request Dec 5, 2024
@adriendupuis
IBX-4064: Search adjustements (#2566)
9d68a72 
* custom.js: "See all results" → "See more results"
* custom.js: No search result highlight on keyboard navigation

(cherry picked from commit 33fc6d9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabrt dabrt dabrt approved these changes

@mnocon mnocon mnocon approved these changes

Assignees
No one assigned
Labels
Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriendupuis @mnocon @dabrt