Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify SiteAccess for translations data migrations #2247

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Specify SiteAccess for translations data migrations #2247

merged 4 commits into from
Jan 4, 2024

Conversation

adriendupuis
Copy link
Contributor

Question Answer
JIRA Ticket CS-11606/support 11606
Versions 4.6, 4.5, 3.3
Edition All

Recommends --siteaccess option with a BO SiteAccess when using multiple languages to avoid loosing translations at export or import time.

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis marked this pull request as ready for review December 13, 2023 15:34
@adriendupuis
Copy link
Contributor Author

adriendupuis commented Dec 13, 2023 •
edited
Loading

Side note:
I found nothing in doc about configuring languages on admin SiteAccess or admin_group.
There might be something to add about this in another PR.

@adamwojs
Copy link
Member

I found nothing in doc about configuring languages on admin SiteAccess or admin_group.
There might be something to add about this in another PR.

It works exactly the same as in case of other frontend accesses 😉

@adriendupuis adriendupuis mentioned this pull request Dec 14, 2023
Merged
7 tasks
@adriendupuis @MagdalenaZuba
Apply suggestions from code review
1350a97 
Co-authored-by: Magdalena Dziadosz <[email protected]>
@adriendupuis adriendupuis merged commit 6ea0043 into master Jan 4, 2024
4 checks passed
@adriendupuis adriendupuis deleted the translations-migration branch January 4, 2024 09:42
adriendupuis added a commit that referenced this pull request Jan 4, 2024
@adriendupuis
Specify SiteAccess for translations data migrations (#2247)
4fbf803 
---------

Co-authored-by: Adrien Dupuis <[email protected]>
Co-authored-by: Magdalena Dziadosz <[email protected]>
(cherry picked from commit 6ea0043)
adriendupuis added a commit that referenced this pull request Jan 4, 2024
@adriendupuis
Specify SiteAccess for translations data migrations (#2247)
2394e78 
Manual cherry-pick to merge exporting_data.md's and importing_data.md's changes back into exporting_and_importing_data.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julitafalcondusza julitafalcondusza julitafalcondusza approved these changes

@reithor reithor reithor approved these changes

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@webhdx webhdx Awaiting requested review from webhdx

@MagdalenaZuba MagdalenaZuba Awaiting requested review from MagdalenaZuba

Assignees
No one assigned
Labels
Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adriendupuis @adamwojs @reithor @MagdalenaZuba @julitafalcondusza