Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cards() enhancement #2241

Closed
wants to merge 5 commits into from
Closed

cards() enhancement #2241

wants to merge 5 commits into from

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Dec 6, 2023

Question Answer
JIRA Ticket
Versions
Edition

Enhance cards

  • Add external URL handling

File that will use cards with this new feature in #2242:
docs/ibexa_products/editions.md

Files already using cards, links to their view in this PR build:

I picked up several randomly, they works as the same as previously.

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

main.py Outdated Show resolved Hide resolved
adriendupuis and others added 2 commits December 11, 2023 15:54
`cards` uses Open Graph meta tags for external URL as they are more optimized for sharing.
@adriendupuis adriendupuis marked this pull request as ready for review December 20, 2023 10:08
@adriendupuis
Copy link
Contributor Author

Merged w/ #2242

@adriendupuis adriendupuis deleted the enh-cards branch January 19, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant