PHP 8: Preventing Fatal error for ezobjectrelationlist datatype #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n data_text is an empty string or null We want to standardize the data_text default value to an empty string because in PHP 8 most of operations with string will throw a Fatal error when passing null. The data_text value is initialized with a null value when adding a new attribute to an existing content class.
|
alongosz
reviewed
Nov 22, 2024
|
@alongosz yeah I am not sure about all the bureaucratic steps to submit a pull request. I think I will create a ticket describing the issue and I will point this as a possible solution hoping in the future there is an official patch for this issue. Update: Created this issue https://issues.ibexa.co/browse/IBX-9259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preventing Fatal error in PHP 8 for ezobjectrelationlist datatype when data_text is an empty string or null
We want to standardize the data_text default value to an empty string because in PHP 8 most of operations with string will throw a Fatal error when passing null. The data_text value is initialized with a null value when adding a new attribute to an existing content class.
Example, execute this in PHP 8.3:
$dom = new DOMDocument('1.0', 'utf-8');
$dom->loadXML('');
PHP Fatal error: Uncaught ValueError: DOMDocument::loadXML(): Argument #1 ($source) must not be empty...
$dom = new DOMDocument('1.0', 'utf-8');
$dom->loadXML(null);
PHP Fatal error: Uncaught ValueError: DOMDocument::loadXML(): Argument #1 ($source) must not be empty in...