-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8566: Fixed postgres language limit #454
Conversation
3175c5a
to
a188172
Compare
Note: There are PR unrelated issues with twig/twig that let some tests fail. |
src/lib/Persistence/Legacy/SharedGateway/DatabasePlatform/AbstractGateway.php
Show resolved
Hide resolved
tests/integration/Core/Repository/ContentService/MaxLanguagesContentServiceTest.php
Show resolved
Hide resolved
This reverts commit 8f93363
861a196
to
e4bada3
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side +1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reproduced and retested.
Checked on postgres and mysql.
Main Issue was in following subquery:
When using postgres the parameter
:language_id
inTHEN (:language_id | 1)
is casted to INT.This can cause a "Numeric value out of range" error.
PR makes this part db-platform aware - using
cast(:language_id as BIGINT)
for postgres.(Note:
cast(:language_id as BIGINT)
would cause an error for mysql as mysql cast does not supportBIGINT
)