Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7418: Added ContentNameCriterion #312

Merged
merged 11 commits into from
Jan 17, 2024
Merged

IBX-7418: Added ContentNameCriterion #312

merged 11 commits into from
Jan 17, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Dec 18, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-7418
Type feature
Target Ibexa version v4.6
BC breaks no
Related PRs ibexa/solr#61, https://github.com/ibexa/elasticsearch/pull/34, ibexa/rest#82

This PR adds new criterion that allows to search by content names.

Examples:

new ContentName('phrase'); 

new ContentName('phra*'); 

new ContentName('*phrase*'); 

new ContentName('phr*se*');

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@ciastektk ciastektk force-pushed the ibx-7418-added-content-name-criterion branch 4 times, most recently from c9c1c39 to 6b11f71 Compare December 19, 2023 11:31
@ciastektk ciastektk marked this pull request as ready for review December 19, 2023 12:00
@ciastektk ciastektk mentioned this pull request Dec 20, 2023
Merged
6 tasks
@ciastektk ciastektk requested a review from a team December 20, 2023 13:48
@ciastektk ciastektk added Feature New feature request Ready for review labels Dec 20, 2023
@ciastektk ciastektk mentioned this pull request Dec 20, 2023
Merged
3 tasks
@ciastektk ciastektk added the Doc needed The changes require some documentation label Dec 20, 2023
@konradoboza konradoboza requested a review from a team December 21, 2023 07:32
@konradoboza konradoboza requested a review from a team December 21, 2023 08:22
alongosz
alongosz reviewed Dec 21, 2023
View reviewed changes
src/lib/Resources/settings/search_engines/legacy/criterion_handlers_common.yml Outdated Show resolved Hide resolved
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/ContentName.php Outdated Show resolved Hide resolved
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/ContentName.php Outdated Show resolved Hide resolved
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/ContentName.php Outdated Show resolved Hide resolved
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/ContentName.php Show resolved Hide resolved
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/ContentName.php Outdated Show resolved Hide resolved
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/ContentName.php Outdated Show resolved Hide resolved
src/lib/Search/Legacy/Content/Common/Gateway/CriterionHandler/ContentName.php Outdated Show resolved Hide resolved
@alongosz alongosz requested a review from a team December 21, 2023 15:38
@ciastektk ciastektk force-pushed the ibx-7418-added-content-name-criterion branch 3 times, most recently from 3aafbb7 to b342923 Compare December 22, 2023 14:00
@ciastektk ciastektk requested a review from alongosz December 22, 2023 14:02
@ciastektk ciastektk force-pushed the ibx-7418-added-content-name-criterion branch from b342923 to f9ad0db Compare January 8, 2024 07:52
@ciastektk ciastektk force-pushed the ibx-7418-added-content-name-criterion branch from f9ad0db to e9daab8 Compare January 8, 2024 10:06
@alongosz alongosz requested a review from a team January 12, 2024 10:24
Steveb-p
Steveb-p approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

We will come back to case insensitive queries and indexing at a later date.

alongosz
alongosz approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we've decided to drop supporting extended syntax for ContentName, as this is meant for FullText only and would've worked OOTB on Solr only.

tomaszszopinski
tomaszszopinski approved these changes Jan 17, 2024
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@ciastektk ciastektk force-pushed the ibx-7418-added-content-name-criterion branch from 078d08f to 71153dc Compare January 17, 2024 13:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 273aa8c into main Jan 17, 2024
19 of 22 checks passed
@alongosz alongosz deleted the ibx-7418-added-content-name-criterion branch January 17, 2024 13:53
alongosz pushed a commit to ibexa/rest that referenced this pull request Jan 17, 2024
@ciastektk
IBX-7418: Added input parser for ContentName criterion (#82)
2d69c56 
For more details see https://issues.ibexa.co/browse/IBX-7418 and #82

Key changes:

* Implemented input parser for ContentName criterion (ibexa/core#312)

* [Tests] Added functional tests coverage
@julitafalcondusza julitafalcondusza removed the Doc needed The changes require some documentation label Apr 19, 2024
@julitafalcondusza julitafalcondusza mentioned this pull request Apr 19, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@webhdx webhdx webhdx approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@kisztof kisztof kisztof approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels
Feature New feature request QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ciastektk @kisztof @Steveb-p @alongosz @webhdx @konradoboza @tomaszszopinski @mikadamczyk @julitafalcondusza