Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect type-hint for Repository Exceptions contracts #279

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Fixed incorrect type-hint for Repository Exceptions contracts #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1ed69f
Fixed incorrect type-hint for Repository Exceptions contracts
alongosz Oct 9, 2023
6fe19c4
[PHPStan] Dropped obsolete error report in tests/.../FilterTest.php
alongosz Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62040,11 +62040,6 @@ parameters:
count: 1
path: tests/lib/Repository/Values/ContentType/FieldDefinitionCollectionTest.php

-
message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertContainsEquals\\(\\) with Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Query\\\\SortClause\\\\Location\\\\Priority and array\\{\\} will always evaluate to false\\.$#"
count: 1
path: tests/lib/Repository/Values/Filter/FilterTest.php

-
message: "#^Method Ibexa\\\\Tests\\\\Core\\\\Repository\\\\Values\\\\Filter\\\\FilterTest\\:\\:getComplexFilterTestData\\(\\) return type has no value type specified in iterable type iterable\\.$#"
count: 1
Expand Down
2 changes: 1 addition & 1 deletion src/contracts/Persistence/Content/UrlAlias/Handler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ public function deleteCorruptedUrlAliases();
*
* @param int $locationId
*
* @throws \Ibexa\Core\Base\Exceptions\BadStateException
* @throws \Ibexa\Contracts\Core\Repository\Exceptions\BadStateException
*/
public function repairBrokenUrlAliasesForLocation(int $locationId);
}
Expand Down
2 changes: 1 addition & 1 deletion src/contracts/Repository/UserPreferenceService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ interface UserPreferenceService
* @param \Ibexa\Contracts\Core\Repository\Values\UserPreference\UserPreferenceSetStruct[] $userPreferenceSetStructs
*
* @throws \Ibexa\Contracts\Core\Repository\Exceptions\UnauthorizedException If the current user user is not allowed to set user preference
* @throws \Ibexa\Core\Base\Exceptions\InvalidArgumentException If the $userPreferenceSetStruct is invalid
* @throws \Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentException If the $userPreferenceSetStruct is invalid
*/
public function setUserPreference(array $userPreferenceSetStructs): void;

Expand Down
2 changes: 1 addition & 1 deletion src/lib/Base/Container/ApiLoader/RepositoryFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public function buildRepository(
* @param \Ibexa\Contracts\Core\Repository\Repository $repository
* @param string $serviceName
*
* @throws \Ibexa\Core\Base\Exceptions\InvalidArgumentException
* @throws \Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentException
*
* @return mixed
*/
Expand Down
Loading