Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed Composite NOT expression #6

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Allowed Composite NOT expression #6

merged 2 commits into from
Oct 2, 2023

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Sep 29, 2023 •
edited
Loading

Question Answer
JIRA issue N/A
Type feature
Target Ibexa version v4.6
BC breaks no

This PR adds the ability for Core Persistence to work with CompositeExpression with NOT type.

https://github.com/doctrine/orm/blob/081ec2ad26ad3351799acd16e2bc4bd5d7e80c77/lib/Doctrine/ORM/Persisters/SqlExpressionVisitor.php#L86-L88

☝️ above behavior is mimicked, since I don't think we have a specified doctrine/collections dependency?

Additionally, the const used in the Doctrine library exists only in 2.x version, which is PHP 8+.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for
    front-end changes).

@Steveb-p Steveb-p requested a review from a team September 29, 2023 08:14
@Steveb-p Steveb-p requested a review from a team September 29, 2023 08:57
@konradoboza konradoboza requested a review from a team September 29, 2023 09:01
@webhdx webhdx requested a review from a team October 2, 2023 08:17
@Steveb-p Steveb-p merged commit 62a007a into main Oct 2, 2023
9 checks passed
@Steveb-p Steveb-p deleted the composite-not branch October 2, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@webhdx webhdx webhdx approved these changes

@alongosz alongosz alongosz approved these changes

Assignees
No one assigned
Labels
Improvement Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Steveb-p @alongosz @webhdx @konradoboza