IBX-8711: Added setting default for struct option in ContentFieldType #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ViniTou
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
But please take a look why there is missing CoreSearch bundle in behat tests.
Also, if there is a slight chance that you could also remove dependency on
use Ibexa\Contracts\Core\Repository\Values\User\UserCreateStruct;
use Ibexa\Contracts\Core\Repository\Values\User\UserUpdateStruct;
here, and move that somehow to user bundle it would be great - or at least create issue for it as I have feeling it would bite us at some point.
ViniTou
changed the title
|
The issue for removing the dependency: https://issues.ibexa.co/browse/IBX-9146 |
adamwojs
reviewed
Nov 18, 2024
|
konradoboza
approved these changes
Nov 19, 2024
tbialcz
approved these changes
Nov 20, 2024
|
QA Approved on Ibexa DXP Commerce 4.6.14 |
juskora
approved these changes
Dec 13, 2024
mikadamczyk
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Option "struct" is required in Ibexa\ContentForms\Form\Type\Content\ContentFieldType but has no default value.
This caused a throwing exception when editing the uploaded image in imageAssetField, when creating a form in Ibexa\Bundle\ImageEditor\Controller\ImageAssetController::buildImageFieldTypeForm().
Added setting a default value for this option.