IBX-8034 Changed reading all content fields in mapToFormData so it does not rely on language code #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly on language code
|
webhdx
reviewed
May 9, 2024
There was a problem hiding this comment.
I'd say ContentUpdateMapper should access fields by languageCode since it's used for both translating and editing. I'm worried this may cause some side effects. This change will affect entire content editing but the issue is in Address Fieldtype and I'd check if something can be done there first.
|
@papcio122 Do you plan to finish this PR or can we close it? I've recommended another solution but haven't heard back from you. |
|
I'm closing this pull request and working on a fix in the fieldtype-address repo as @webhdx suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changed reading all content fields in mapToFormData so it does not rely on language code because it caused exceptions when editing translations with address field