IBX-6839: [Smart mode] As the User I want to view Authors tab with only selected data #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisztof
force-pushed
the
IBX-6839-authors-tab
branch
from
b93bd69 to
c3f6a01
Compare
ViniTou
approved these changes
Oct 30, 2023
mikadamczyk
requested changes
Oct 30, 2023
|
SonarCloud Quality Gate failed.
|
webhdx
reviewed
Oct 31, 2023
ViniTou
requested changes
Oct 31, 2023
kisztof
force-pushed
the
IBX-6839-authors-tab
branch
from
90b8f31 to
09859e4
Compare
kisztof
changed the title
adamwojs
approved these changes
Nov 3, 2023
Steveb-p
approved these changes
Nov 6, 2023
| use Symfony\Contracts\Translation\TranslatorInterface; | ||
| use Twig\Environment; | ||
|
|
||
| class AuthorsTab extends AbstractEventDispatchingTab implements OrderedTabInterface |
There was a problem hiding this comment.
Suggested change
| class AuthorsTab extends AbstractEventDispatchingTab implements OrderedTabInterface | |
| final class AuthorsTab extends AbstractEventDispatchingTab implements OrderedTabInterface |
There was a problem hiding this comment.
Tabs cannot be marked as final.
kisztof
force-pushed
the
IBX-6839-authors-tab
branch
2 times, most recently
from
b90c00c to
913960c
Compare
mnocon
requested changes
Nov 13, 2023
There was a problem hiding this comment.
The implemented design differs from what we have in Figma (confirmed with Ida):
- The tab should be the last one
- The "Published"/"Modified" dates are missing
- The view differs (single row vs two rows)
Otherwise looks good, correct author data is displayed ✅
Figma:
PR:
Co-authored-by: Dawid Parafiński <[email protected]>
Co-authored-by: Mikolaj Adamczyk <[email protected]>
Co-authored-by: Mikolaj Adamczyk <[email protected]>
Co-authored-by: Mikolaj Adamczyk <[email protected]>
Co-authored-by: Mikolaj Adamczyk <[email protected]>
Co-authored-by: Mikolaj Adamczyk <[email protected]>
kisztof
force-pushed
the
IBX-6839-authors-tab
branch
from
7f429df to
6832b6c
Compare
konradoboza
reviewed
Nov 20, 2023
Co-authored-by: Konrad Oboza <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Minor design fixes will be provided at later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new Authors tab.
Checklist:
$ composer fix-cs)