Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6649: Added support for spell checking #923

Merged
merged 2 commits into from
Dec 5, 2023
Merged

IBX-6649: Added support for spell checking #923

merged 2 commits into from
Dec 5, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Sep 28, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6649
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Added "Did you mean X?" in global search. PR depends on

Screenshots

Only to demonstrate feature. I need design & frontend teams help here 😉

image

image

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs adamwojs mentioned this pull request Sep 28, 2023
Merged
6 tasks
@adamwojs adamwojs added the Doc needed The changes require some documentation label Nov 3, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
68.8% 68.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@adamwojs adamwojs mentioned this pull request Dec 5, 2023
Merged
6 tasks
@adamwojs adamwojs marked this pull request as ready for review December 5, 2023 22:47
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs merged commit 7845004 into main Dec 5, 2023
22 of 23 checks passed
@adamwojs adamwojs deleted the ibx_6649 branch December 5, 2023 23:05
@julitafalcondusza julitafalcondusza removed the Doc needed The changes require some documentation label Apr 19, 2024
@julitafalcondusza julitafalcondusza mentioned this pull request Apr 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@adamwojs @konradoboza @mikadamczyk @Nattfarinn @ciastektk @dew326 @ViniTou @julitafalcondusza