IBX-6589: Added optional parameter siteAccessList to SiteaccessResolver #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
ViniTou
reviewed
Sep 19, 2023
There was a problem hiding this comment.
Couldnt SiteAccessService::getAll() method result be cached instead of passing this for multiple layers?
Or maybe the list to iterate should be set in a constructor if for some reason this needs to vary from checking on all siteaccesses.
Also, could you show how much we gain by this if this is performance related?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optional parameter
siteAccessListtoSiteaccessResolver::getSiteAccessesListForContentandSiteaccessResolver::getSiteAccessesListForLocationmethods, to only iterate over the passed SiteAccesses list.This will improve performance when iterating over all SiteAccesses are not needed.
Checklist:
$ composer fix-cs)