Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8470: Upgraded codebase to Symfony 6 #1415

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Dec 27, 2024

Caution

This is a part of bigger set of changes, to be merged together when ready

  • Remove TMP commits before merge
🎫 Issue IBX-8470

Related PRs:

Description:

This PR bumps Symfony to v6 with necessary codebase upgrades.

Key changes:

  • [Composer] Dropped obsolete dependency on ci-scripts
  • Moved RichTextTypeExtension out of AdminUI to RichText Bundle
  • [Composer] Dropped cyclic dependency on ibexa/fieldtype-richtext
  • [Composer] Bumped Symfony packages requirements to ^6.4
  • [Composer] Bumped Pagerfanta to v3
  • [Composer] Bumped 3rd party translation bundles for Symfony 6
  • Aligned codebase with Pagerfanta v3
  • [Tests] Upgraded Symfony Forms tests to Symfony 6
  • Fixed incorrect type-hinting of Form DTO ContentTypesDeleteData
  • Aligned type-hints after making core SearchResult templated
  • Rebranded Legacy Pagerfanta View {{KEY_CHANGES}} Template class names
  • Defined strict types for FormActionEvent
  • Upgraded Symfony Forms Choice Loaders to Symfony 6
  • Fixed incorrect type-hinting of Form DTO BookmarkRemoveData
  • Aligned NotificationTranslationExtractor with newer version of PhpParser
  • Replaced usage of Location::$pathString magic getter in UDWBasedMapper
  • Upgraded Symfony validators extension points codebase to Symfony 6
  • [Tests] Aligned type-hints after making core SearchResult templated
  • [PHPStan] Aligned baseline after the changes

QA:

Sanities in the form of regression tests.

Documentation:

No documentation required.

@alongosz alongosz marked this pull request as ready for review December 31, 2024 14:17
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
16.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants