Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9285: Navigation anchor on content creation/edition not working with diacritical marks #1410

Merged
merged 2 commits into from
Dec 19, 2024
Merged

IBX-9285: Navigation anchor on content creation/edition not working with diacritical marks #1410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ae5864
IBX-9285: Navigation anchor on content creation/edition not working w…
lucasOsti Dec 13, 2024
ecbc3d6
phpstan
lucasOsti Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ parameters:
path: src/bundle/Controller/ObjectStateController.php

-
message: "#^Property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ObjectState\\\\ObjectStateCreateStruct\\:\\:\\$names \\(array\\<string\\>\\) does not accept array\\<int\\|string, string\\|null\\>\\.$#"
message: "#^Property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ObjectState\\\\ObjectStateCreateStruct\\:\\:\\$names \\(array\\<string\\>\\) does not accept array\\<string\\|null\\>\\.$#"
count: 1
path: src/bundle/Controller/ObjectStateController.php

Expand Down Expand Up @@ -656,7 +656,7 @@ parameters:
path: src/bundle/Controller/ObjectStateGroupController.php

-
message: "#^Property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ObjectState\\\\ObjectStateGroupCreateStruct\\:\\:\\$names \\(array\\<string\\>\\) does not accept array\\<int\\|string, string\\|null\\>\\.$#"
message: "#^Property Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ObjectState\\\\ObjectStateGroupCreateStruct\\:\\:\\$names \\(array\\<string\\>\\) does not accept array\\<string\\|null\\>\\.$#"
count: 1
path: src/bundle/Controller/ObjectStateGroupController.php

Expand Down
2 changes: 1 addition & 1 deletion src/bundle/Resources/views/themes/admin/ui/menu/anchor_menu.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
{%- if loop.first %}
{%- set itemClass = itemClass ~ ' ibexa-anchor-navigation-menu__sections-item-btn--active' %}
{%- endif %}
{%- do item.setAttribute('data-target-id', "#" ~ item.getAttribute('data-target-id')) -%}
{%- do item.setAttribute('data-target-id', "#" ~ item.getAttribute('data-target-id')|lower|slug) -%}
{%- do item.setAttribute('class', (item.getAttribute('class') ~ ' ' ~ itemClass)|trim) -%}
{%- do item.setAttribute('type', 'button') -%}
{%- do item.setLabelAttribute('class', 'ibexa-anchor-navigation-menu__sections-item-btn-label') -%}
Expand Down
Loading