IBX-9289: NodeFactory optimization
#1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Dec 6, 2024
ciastektk
approved these changes
Dec 6, 2024
mikadamczyk
approved these changes
Dec 6, 2024
Steveb-p
approved these changes
Dec 6, 2024
konradoboza
approved these changes
Dec 6, 2024
tbialcz
approved these changes
Dec 9, 2024
lucasOsti
approved these changes
Dec 11, 2024
tomaszszopinski
force-pushed
the
ibx-9289-node-factory-performance
branch
from
6d66425 to
01d0cfc
Compare
|
tomaszszopinski
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
https://github.com/ibexa/content-tree/pull/88
Description:
We want to avoid loading whole content in the
NodeFactorybecause of the obvious performance problem.Translations will be served in the
loadNodeExtendedInfoActionfor theNodeExtendedInfoVisitordirectly as we only need them for previewing the "Preview" menu item in theibexa/content-treepackage.The rest of properties fetched from
API\Contentcan be fetched fromAPI\ContentInfo:versionNoandmainLanguageCode.Links to BF profiles are present in the ticket's comment.